Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd938dde authored by Jiyong Park's avatar Jiyong Park
Browse files

don't include liblog to APEXes 

liblog is a platform library that provides stable C API. There is no
need to include the library, especialy by statically linking to it, in
any APEX. It not only wastes the storage/ram, but also is incorrect
because the socket interface to logd which is implemented in liblog is
not guaranteed to be stable.

Fixing this issue by converting static_libs: ["liblog"] into
shared_libs: ["liblog"], in which case the dependency to the library
is satisfied via the stub variant of the library.

Bug: 151051671
Test: m
Change-Id: I1573e2d7c3a79f27337dddf24c6e8d0c8189213f
parent 6cb2be07

Android.bp

+6 −1
Original line number Diff line number Diff line
@@ -80,7 +80,6 @@ cc_library { 
        "libbase",

        "libcutils",

        "libjsoncpp",

        "liblog", //Used by libstatslog_resolv

        "libnetdutils",

        "libprotobuf-cpp-lite",

        "libstatslog_resolv",
@@ -95,9 +94,15 @@ cc_library { 
    // integrity check (against a checksum) that is not supported for static

    // libs. See http://b/141248879

    // We're also adding libssl here to treat it consistently.

    // liblog is added as a shared library because it provides stable C API

    // from the platform; we don't need to include it in this module by

    // statically linking to it. Doing so is even dangerous because the socket

    // protocol to logd implemented in the library isn't guaranteed to be

    // stable. See b/151051671

    shared_libs: [

        "libbinder_ndk",

        "libcrypto",

        "liblog", //Used by libstatslog_resolv

        "libssl",

    ],

    header_libs: [