Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96f3dd08 authored by Mike Yu's avatar Mike Yu
Browse files

Test: Fail DoHFFITest.SmokeTest if no network has connectivity 

Fail the test if it's run on a device that has no internet
connectivity, so we won't miss possible problems.

Bug: 245472638
Test: atest doh_ffi_test without any network connected
Change-Id: Ifea9fb180321dd75af88b964b682cd68012aed18
parent 9ab8bba6

tests/doh_ffi_test.cpp

+2 −8
Original line number Original line Diff line number Diff line
@@ -78,20 +78,14 @@ class DoHFFITest : public NetNativeTestBase { 




TEST_F(DoHFFITest, SmokeTest) {

TEST_F(DoHFFITest, SmokeTest) {

    getNetworkForDns(&dnsNetId);

    getNetworkForDns(&dnsNetId);

    if (dnsNetId < MINIMAL_NET_ID) {

    ASSERT_GE(dnsNetId, MINIMAL_NET_ID) << "No available networks";

        GTEST_SKIP() << "No available networks";

    }



    LOG(INFO) << "dnsNetId: " << dnsNetId;

    LOG(INFO) << "dnsNetId: " << dnsNetId;





    const bool have_ipv4 = haveIpv4();

    const bool have_ipv4 = haveIpv4();

    const bool have_ipv6 = haveIpv6();

    const bool have_ipv6 = haveIpv6();

    if (!have_ipv4 && !have_ipv6) {

    ASSERT_TRUE(have_ipv4 | have_ipv6) << "No connectivity on network " << dnsNetId;

        GTEST_SKIP() << "No connectivity on network " << dnsNetId;

    }





    const static char* server_ip = have_ipv6 ? GOOGLE_SERVER_IPV6 : GOOGLE_SERVER_IP;

    const static char* server_ip = have_ipv6 ? GOOGLE_SERVER_IPV6 : GOOGLE_SERVER_IP;



    auto validation_cb = [](uint32_t netId, bool success, const char* ip_addr, const char* host) {

    auto validation_cb = [](uint32_t netId, bool success, const char* ip_addr, const char* host) {

        EXPECT_EQ(netId, dnsNetId);

        EXPECT_EQ(netId, dnsNetId);

        EXPECT_TRUE(success);

        EXPECT_TRUE(success);