Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26bbf12e authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Temporarily disable security checks. 

There have been several obscure regressions that have been uncovered
as part of enabling these checks, and we'll need to design a more
holistic strategy for handling self-calls before enabling again.

Bug: 188391719
Test: none
Change-Id: I5720bed3f66ba87e52d0348157b29b921b869032
parent da7c2f35

src/com/android/bluetooth/Utils.java

+8 −4
Original line number Diff line number Diff line
@@ -447,7 +447,8 @@ public final class Utils { 
    @SuppressLint("AndroidFrameworkRequiresPermission")

    private static boolean checkPermissionForDataDelivery(Context context, String permission,

            AttributionSource attributionSource, String message) {

        attributionSource.enforceCallingUid();

        // STOPSHIP(b/188391719): enable this security enforcement

        // attributionSource.enforceCallingUid();

        final int result = PermissionChecker.checkPermissionForDataDeliveryFromDataSource(

                context, permission, PID_UNKNOWN,

                new AttributionSource(context.getAttributionSource(), attributionSource), message);
@@ -688,7 +689,8 @@ public final class Utils { 
            return false;

        }



        attributionSource.enforceCallingUid();

        // STOPSHIP(b/188391719): enable this security enforcement

        // attributionSource.enforceCallingUid();

        if (PermissionChecker.checkPermissionForDataDeliveryFromDataSource(

                context, ACCESS_COARSE_LOCATION, PID_UNKNOWN,

                new AttributionSource(context.getAttributionSource(), attributionSource),
@@ -715,7 +717,8 @@ public final class Utils { 
            return false;

        }



        attributionSource.enforceCallingUid();

        // STOPSHIP(b/188391719): enable this security enforcement

        // attributionSource.enforceCallingUid();

        if (PermissionChecker.checkPermissionForDataDeliveryFromDataSource(

                context, ACCESS_FINE_LOCATION, PID_UNKNOWN,

                new AttributionSource(context.getAttributionSource(), attributionSource),
@@ -748,7 +751,8 @@ public final class Utils { 
            return false;

        }



        attributionSource.enforceCallingUid();

        // STOPSHIP(b/188391719): enable this security enforcement

        // attributionSource.enforceCallingUid();

        if (PermissionChecker.checkPermissionForDataDeliveryFromDataSource(

                context, ACCESS_FINE_LOCATION, PID_UNKNOWN,

                new AttributionSource(context.getAttributionSource(), attributionSource),