Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79572f6a authored by Federico Baron's avatar Federico Baron
Browse files

Fix margins/padding in widget picker 

Widget picker had weird issues because when we adjusted margin/padding on orientation change we were changing margin/padding of things that didn't have that amount set initially. The function onContentHorizontalMarginChanged was changing the margin/padding of recyclerviews and the stickyheaderlayout. This corrects the issue and there should be no margin/padding errors when we rotate, as the recyclerviews and stickyheaderlayout have the right margin set from the beginning.

Fix: 269348654
Test: Go to widget picker on tablet, rotate to landscape/portrait, rotate back to landscape/portrait. Verify that marins on the sides of widget picker are correct.
Change-Id: If5a26ae23b440c8a4a55cd0029042b2a5d5398b3
parent 56ebfc49

res/layout/widgets_full_sheet_paged_view.xml

+3 −5
Original line number Diff line number Diff line
@@ -23,19 +23,20 @@ 
        android:clipToPadding="false"

        android:layout_below="@id/collapse_handle"

        android:descendantFocusability="afterDescendants"

        android:paddingHorizontal="@dimen/widget_list_horizontal_margin"

        launcher:pageIndicator="@+id/tabs" >



        <com.android.launcher3.widget.picker.WidgetsRecyclerView

            android:id="@+id/primary_widgets_list_view"

            android:layout_width="match_parent"

            android:layout_height="match_parent"

            android:paddingHorizontal="@dimen/widget_list_horizontal_margin"

            android:clipToPadding="false" />



        <com.android.launcher3.widget.picker.WidgetsRecyclerView

            android:id="@+id/work_widgets_list_view"

            android:layout_width="match_parent"

            android:layout_height="match_parent"

            android:paddingHorizontal="@dimen/widget_list_horizontal_margin"

            android:clipToPadding="false" />



    </com.android.launcher3.widget.picker.WidgetPagedView>
@@ -47,6 +48,7 @@ 
        android:layout_height="wrap_content"

        android:layout_below="@id/collapse_handle"

        android:paddingBottom="0dp"

        android:layout_marginHorizontal="@dimen/widget_list_horizontal_margin"

        android:clipToOutline="true"

        android:orientation="vertical">
@@ -57,7 +59,6 @@ 
            android:gravity="center_horizontal"

            android:textSize="24sp"

            android:layout_marginTop="24dp"

            android:paddingHorizontal="@dimen/widget_list_horizontal_margin"

            android:textColor="?android:attr/textColorSecondary"

            android:text="@string/widget_button_text"/>
@@ -68,7 +69,6 @@ 
            android:elevation="0.1dp"

            android:background="?android:attr/colorBackground"

            android:paddingBottom="8dp"

            android:paddingHorizontal="@dimen/widget_list_horizontal_margin"

            launcher:layout_sticky="true">

            <include layout="@layout/widgets_search_bar" />

        </FrameLayout>
@@ -80,7 +80,6 @@ 
            android:layout_marginTop="8dp"

            android:background="@drawable/widgets_surface_background"

            android:paddingVertical="@dimen/recommended_widgets_table_vertical_padding"

            android:layout_marginHorizontal="@dimen/widget_list_horizontal_margin"

            android:visibility="gone" />



        <com.android.launcher3.workprofile.PersonalWorkSlidingTabStrip
@@ -90,7 +89,6 @@ 
            android:gravity="center_horizontal"

            android:orientation="horizontal"

            android:paddingVertical="8dp"

            android:layout_marginHorizontal="@dimen/widget_list_horizontal_margin"

            android:background="?android:attr/colorBackground"

            style="@style/TextHeadline"

            launcher:layout_sticky="true">

res/layout/widgets_full_sheet_recyclerview.xml

+2 −2
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ 
        android:layout_below="@id/collapse_handle"

        android:layout_width="match_parent"

        android:layout_height="match_parent"

        android:layout_marginHorizontal="@dimen/widget_list_horizontal_margin"

        android:paddingHorizontal="@dimen/widget_list_horizontal_margin"

        android:clipToPadding="false" />



    <!-- SearchAndRecommendationsView without the tab layout as well -->
@@ -30,7 +30,7 @@ 
        android:layout_height="wrap_content"

        android:layout_below="@id/collapse_handle"

        android:paddingBottom="16dp"

        android:paddingHorizontal="@dimen/widget_list_horizontal_margin"

        android:layout_marginHorizontal="@dimen/widget_list_horizontal_margin"

        android:clipToOutline="true"

        android:orientation="vertical">