Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 698275c3 authored by Catherine Liang's avatar Catherine Liang
Browse files

Fix color picker scroll position resets on select (1/2)

After a color option is selected in the color picker, the scroll
position jumps back to the start, rather than saving and restoring the
scroll position using save and restore instance state. The regression
was caused by a combination of 1) color picker restarting twice from
config change updates, 2) the view.post callback not being removed when
the view is destroyed, leading to two consecutive calls, and 3) recycler
view's restore instance state was called before the data was fully
binded. The code to update color options on selection was
also removed for now because it interferes with the config change
restart and saving instance state. This should be brought back once the
config change restart is disabled.

Bug: 298898592
Test: manually verified
Change-Id: Ic694fb3e73dffee1d5b8bcac8e417de886e7a0ae
parent ee17d9a1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment