Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 385ce933 authored by Chihhang Chuang's avatar Chihhang Chuang Committed by chihhangchuang
Browse files

Fix abnormal ripple effect of bottom tab

Root cause: ThemeFragment and GridFragment are updating the bottom action bar visibility from Visible to Gone quickly, the visiblity change of bottom action bar also update the visiblity of bottom nav. So we will see the ripple effect being abnormal.

Solution:
1. Restrict BottomNav to update visibility, not every time.
2. Make sure ThemeFragment and GridFragment didn't update visibility of BottomActionBar several times when initializing.

Video: https://drive.google.com/file/d/1p5cSPnZ6kHXDeXiTZIavJ_mOKMu7wAtY/view?usp=sharing

Test: Manually
Fixes: 159685933
Change-Id: Ia61d7af21c143c9da5e441cbcef34c0397cb3181
parent b85eff5a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment