Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

v1-t: Fix invalid advancedPrivacy settings intent

Vincent Bourgmayer requested to merge 1277-t-fix-advancedPrivacy-intent into v1-t

Description

Intent for AdvancedPrivacy in settings stayed on PrivacyCentral which cause crash in some case to open the app

⚠ Got the issue with local build, but it's weird it doesn't happens with gitlab build or prod's version...

La modif du nom des packages date de la semaine derniere,donc normalement, elle a pas été embarqué dans la 1.11 (issue 1200)

If approval is given, the commits needs to be cherry picked into other branches

Screenshots

Technical details

--------- beginning of crash
05-12 10:55:09.860  4328  4328 E AndroidRuntime: FATAL EXCEPTION: main
05-12 10:55:09.860  4328  4328 E AndroidRuntime: Process: com.android.settings, PID: 4328
05-12 10:55:09.860  4328  4328 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.android.settings/com.android.settings.SubSettings}: android.content.ActivityNotFoundException: Unable to find explicit activity class {foundation.e.advancedprivacy/foundation.e.privacycentralapp.main.MainActivity}; have you declared this activity in your AndroidManifest.xml?
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3431)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3595)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:223)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:7664)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: Caused by: android.content.ActivityNotFoundException: Unable to find explicit activity class {foundation.e.advancedprivacy/foundation.e.privacycentralapp.main.MainActivity}; have you declared this activity in your AndroidManifest.xml?
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:2069)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Instrumentation.execStartActivity(Instrumentation.java:1731)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Activity.startActivityForResult(Activity.java:5314)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:527)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Activity.startActivityForResult(Activity.java:5272)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:513)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Activity.startActivity(Activity.java:5658)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.core.content.ContextCompat.startActivity(ContextCompat.java:252)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentHostCallback.onStartActivityFromFragment(FragmentHostCallback.java:166)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.Fragment.startActivity(Fragment.java:1369)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.Fragment.startActivity(Fragment.java:1357)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at com.android.settings.privacy.AdvancedPrivacyDashboardFragment.onCreate(AdvancedPrivacyDashboardFragment.java:43)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.Fragment.performCreate(Fragment.java:2883)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:484)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1312)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1477)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentTransition.addToFirstInLastOut(FragmentTransition.java:1246)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentTransition.calculateFragments(FragmentTransition.java:1128)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentTransition.startTransitions(FragmentTransition.java:135)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2112)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2055)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1957)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.executePendingTransactions(FragmentManager.java:572)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at com.android.settings.SettingsActivity.switchToFragment(SettingsActivity.java:586)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at com.android.settings.SettingsActivity.launchSettingFragment(SettingsActivity.java:374)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at com.android.settings.SettingsActivity.onCreate(SettingsActivity.java:282)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:7994)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:7978)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1313)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3404)
05-12 10:55:09.860  4328  4328 E AndroidRuntime: 	... 11 more
05-12 10:55:09.865  1237  5049 I DropBoxManagerService: add tag=system_app_crash isTagEnabled=true flags=0x2

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/1277

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Merge request reports