This project is mirrored from https://github.com/LineageOS/android_packages_apps_Settings.git. Pull mirroring updated .
  1. 16 Feb, 2022 1 commit
  2. 12 Feb, 2022 1 commit
  3. 06 Oct, 2021 3 commits
    • /e/ robot's avatar
      bc3c6723
    • Hugh Chen's avatar
      RESTRICT AUTOMERGE Fix unable to send file via OPP · 40826f1d
      Hugh Chen authored
      
      
      Bluetooth app will indicate BluetoothOppReceiver to receive
      device picker intent. But for fix the security issue we
      removed the setClassName() method in ag/14111132 to avoid attack.
      It causes BluetoothOppReceiver cannot receive the intent.
      
      This CL will compare to calling package name with launch package name.
      If they are not equal, the setClassName() will not invoke.
      
      Bug: 186490534
      Bug: 179386960
      Bug: 179386068
      
      [basilgello: Backport to LineageOS 14.1]
      Signed-off-by: default avatarVasyl Gello <vasek.gello@gmail.com>
      
      Test: make RunSettingsRoboTests -j56
      Change-Id: Ia51528f2a44ab73edbc86899ca0846d3262fe1f0
      (cherry picked from commit bb5be240)
      (cherry picked from commit 2deb2829)
      40826f1d
    • Hugh Chen's avatar
      RESTRICT AUTOMERGE Fix bluetooth settings will broadcast to anywhere when some cases · 319c2e5a
      Hugh Chen authored
      
      
      BluetoothPermissionActivity and DevicePickerFragment will send
      broadcast to return the result to calling apps. As this broadcast
      intent is from Settings with uid 1000, it will be sent to any
      protected BroadcastReceivers in the device. It can make an attacker
      send broadcast to protected BroadcastReceivers like factory reset intent
      (android/com.android.server.MasterClearReceiver) via
      BluetoothPermissionActivity or DevicePickerFragment.
      
      This CL will not allow to set package name and class name to avoid
      the attacker.
      
      Bug: 179386960
      Bug: 179386068
      Test: make -j42 RunSettingsRoboTests and use test apk to manually test
      to verify factory reset not started and no system UI notification.
      
      [basilgello: Backport to 14.1]
      Signed-off-by: default avatarVasyl Gello <vasek.gello@gmail.com>
      
      Change-Id: Id27a78091ab578077853b8fbb97a4422cff0a158
      (cherry picked from commit 8adedc62)
      (cherry picked from commit c2adcb2d)
      319c2e5a
  4. 24 Aug, 2021 3 commits
  5. 19 Jul, 2021 1 commit
  6. 08 Jun, 2021 2 commits
  7. 05 May, 2021 1 commit
    • Andras Kloczl's avatar
      Prevent using invalid result uri during multi user image change · a5ced096
      Andras Kloczl authored
      Test: manual
      Bug: 172939189
      Change-Id: I258c305f825da94474c8027828e3b9707b463699
      Merged-In: I258c305f825da94474c8027828e3b9707b463699
      Merged-In: I3e6f6200e82e86d6a2085652906ad2d0d44814f5
      Merged-In: Id2e598878b3250e8b3590905c6def561e2437d55
      Merged-In: I15e15ad88b768a5b679de32c5429d921d850a3cb
      (cherry picked from commit 6746add6)
      a5ced096
  8. 16 Apr, 2021 1 commit
  9. 06 Apr, 2021 2 commits
    • Hugh Chen's avatar
      RESTRICT AUTOMERGE Update String · ae2a9257
      Hugh Chen authored
      Remove brackets.
      
      Bug: 176106404
      Bug: 167403112
      Test: build pass
      Change-Id: Ib9a3c4fa3c6ea1ca54244d672bdc3e12d51a719f
      (cherry picked from commit 48ec7459)
      ae2a9257
    • Hugh Chen's avatar
      RESTRICT AUTOMERGE Fix phishing attacks over Bluetooth due to unclear warning message · 5b8b4a01
      Hugh Chen authored
      Before this CL, there is a possible phishing attack allowing a malicious
      BT device to acquire permissions based on insufficient information
      presented to the user in the consent dialog. This could lead to local
      escalation of privilege with no additional execution privileges needed.
      User interaction is needed for exploitation.
      
      This CL add more prompts presented for users to avoid phishing attacks.
      
      Merge Conflict Notes:
      There were a number of entries in strings.xml that did not exist on this
      branch. However, as the CL only adds new entries rather than modifying
      old ones this should not cause a problem. There were no merge conflicts
      in the java files.
      
      Bug: 167403112
      Test: send intent to test right prompts message is pop up. make -j42 RunSettingsRoboTests
      Change-Id: Idc6ef558b692115bb82ea58cf223f5919b618633
      (cherry picked from commit 9037e43f)
      5b8b4a01
  10. 10 Mar, 2021 1 commit
  11. 07 Mar, 2021 1 commit
  12. 17 Feb, 2021 1 commit
  13. 05 Feb, 2021 1 commit
  14. 03 Feb, 2021 2 commits
  15. 29 Oct, 2020 1 commit
  16. 28 Oct, 2020 1 commit
    • Sunny Shao's avatar
      Enable the filterTouchesWhenObscured in Special app access · b26ecda5
      Sunny Shao authored
      - Enable the filterTouchesWhenObscured attribute on all toggle
        switches in all pages of the special app access
      
      Bug: 155288585
      Test: make RunSettingsRoboTests
      Merged-In: I011cfe4b7e4e624a8338332ac47a353f7f3ab661
      Change-Id: I85842db3faa558ea61bc878ca76ff6d8ce1a4b03
      (cherry picked from commit 7359b384)
      b26ecda5
  17. 27 Oct, 2020 2 commits
  18. 06 Oct, 2020 1 commit
  19. 09 Sep, 2020 2 commits
  20. 23 Aug, 2020 1 commit
  21. 22 Aug, 2020 1 commit
    • Sunny Shao's avatar
      Allows to launch only authenticator owned activities · 6048a5c6
      Sunny Shao authored
      - 3rd party developers can define himself-authenticator
        and use the accountPreferences attribute to load the
        predefined preference UI.
      - If a developer defines an action intent to launch the
        other activity in xml and it would return true due
        to the true exported attribute and no permission.
      - To avoid launching arbitrary activity. Here allows
        to launch only authenticator owned activities.
      
      Bug: 150946634
      Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.accounts
      Test: PoC app
      Change-Id: I5ce1a0b3838db7b3fbe48c6ea23d5f093d625cdb
      Merged-In: I5ce1a0b3838db7b3fbe48c6ea23d5f093d625cdb
      (cherry picked from commit d6d8f988)
      (cherry picked from commit 4b6e82fd)
      6048a5c6
  22. 06 Jun, 2020 1 commit
  23. 02 Jun, 2020 2 commits
  24. 20 May, 2020 2 commits
  25. 05 May, 2020 1 commit
    • Mill Chen's avatar
      RESTRICT AUTOMERGE · 121236d1
      Mill Chen authored
      Allow LockScreenPattern to be launched in the pinning screen
      
      If work profile lock is enabled and work app is pinned, users will get a
      black/white screen on the phone. That's because Settings is prevented
      from other apps launch any pages of Settings in the pinning mode.
      
      In order to launch some pages of Settings from other apps, we add a
      condition to the preventive mechanism and allow the activity inherited
      from SettingsBaseActivity to override the condition to have the activity
      to be launched from other apps in the pinning mode.
      
      Bug: 137015265
      Bug: 135604684
      Test: manual test
      Change-Id: I8070de79a83350d1658efcb19e983669dad0e673
      Merged-In: I8070de79a83350d1658efcb19e983669dad0e673
      (cherry picked from commit 3f4d3b4a)
      121236d1
  26. 14 Feb, 2020 1 commit
  27. 10 Feb, 2020 1 commit
  28. 05 Feb, 2020 1 commit
    • Mill Chen's avatar
      Prevent accounts page directly opening in screen pinning mode · b2087715
      Mill Chen authored
      In Settings there is no auth mechanism to prevent accounts page being
      opened in screen pinning mode. This CL makes it so that when users are
      trying to navigate to any pages in Settings from other apps in screen
      pinning mode, Settings app will directly close its page.
      
      Bug: 137015265
      Bug: 135604684
      Test: manual
      Change-Id: If26eda408a9ef6fa03ad82e5bee51bb7185950d6
      Merged-In: If26eda408a9ef6fa03ad82e5bee51bb7185950d6
      (cherry picked from commit f3242dab)
      (cherry picked from commit ad2502a9)
      b2087715
  29. 21 Jan, 2020 1 commit