Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f265dbc4 authored by Matthew Fritze's avatar Matthew Fritze
Browse files

Fix bug preventing users from clicking settings suggestions twice

In an attempt to fix a monkey test crash which would open a
suggestion, click back and tap the same one again. The change
unfortunately prevented this for all users, but was not caught
because of a debug flag set on my device. A unit test will be added
to master to catch such cases, as tracked by this bug:
b/31937112

Change-Id: Ib1cff07e54903df687454bdbf2ed1416485ab34f
Fixes: 31926102
Test: Manual
parent 9c54a67d
Loading
Loading
Loading
Loading
+1 −5
Original line number Diff line number Diff line
@@ -1273,11 +1273,7 @@ public class SettingsActivity extends SettingsDrawerActivity
        if (intent == null || ActivityManager.isUserAMonkey()) {
            return;
        }
        final ComponentName componentName = intent.getComponent();
        if (componentName.equals(mCurrentSuggestion)) {
            return;
        }
        mCurrentSuggestion = componentName;
        mCurrentSuggestion = intent.getComponent();
        startActivityForResult(intent, REQUEST_SUGGESTION);
    }