Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebe36cf9 authored by changbetty's avatar changbetty
Browse files

[Mainline] To use @SystemApi to replace non-formal APIs for mainline 

    - getResourcesForSubId(Context, int, boolean)
      - @SystemApi getResourcesForSubId(Context, int)
    - isUsableSubIdValue(int subId)
      - public isUsableSubscriptionId(int subId)

Bug: 147206736
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ResetNetworkTest
      make RunSettingsRoboTests ROBOTEST_FILTER=ResetNetworkConfirmTest
      make RunSettingsRoboTests ROBOTEST_FILTER=CellularFallbackPreferenceControllerTest
      make RunSettingsRoboTests ROBOTEST_FILTER=WifiCallingSettingsForSubTest

Change-Id: I1a67db80b114a438afda7d45af90e54af38703c3
parent 6b7b92ce

src/com/android/settings/ResetNetwork.java

+3 −3
Original line number Diff line number Diff line
@@ -170,13 +170,13 @@ public class ResetNetwork extends InstrumentedFragment { 
        if (mSubscriptions != null && mSubscriptions.size() > 0) {

            // Get the default subscription in the order of data, voice, sms, first up.

            int defaultSubscription = SubscriptionManager.getDefaultDataSubscriptionId();

            if (!SubscriptionManager.isUsableSubIdValue(defaultSubscription)) {

            if (!SubscriptionManager.isUsableSubscriptionId(defaultSubscription)) {

                defaultSubscription = SubscriptionManager.getDefaultVoiceSubscriptionId();

            }

            if (!SubscriptionManager.isUsableSubIdValue(defaultSubscription)) {

            if (!SubscriptionManager.isUsableSubscriptionId(defaultSubscription)) {

                defaultSubscription = SubscriptionManager.getDefaultSmsSubscriptionId();

            }

            if (!SubscriptionManager.isUsableSubIdValue(defaultSubscription)) {

            if (!SubscriptionManager.isUsableSubscriptionId(defaultSubscription)) {

                defaultSubscription = SubscriptionManager.getDefaultSubscriptionId();

            }

src/com/android/settings/ResetNetworkConfirm.java

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ public class ResetNetworkConfirm extends InstrumentedFragment { 
    private void restoreDefaultApn(Context context) {

        Uri uri = Uri.parse(ApnSettings.RESTORE_CARRIERS_URI);



        if (SubscriptionManager.isUsableSubIdValue(mSubId)) {

        if (SubscriptionManager.isUsableSubscriptionId(mSubId)) {

            uri = Uri.withAppendedPath(uri, "subId/" + String.valueOf(mSubId));

        }

src/com/android/settings/wifi/CellularFallbackPreferenceController.java

+1 −2
Original line number Diff line number Diff line
@@ -68,8 +68,7 @@ public class CellularFallbackPreferenceController extends TogglePreferenceContro 


    @VisibleForTesting

    Resources getResourcesForSubId(int subscriptionId) {

        return SubscriptionManager.getResourcesForSubId(mContext, subscriptionId,

                false /* useRootLocale */);

        return SubscriptionManager.getResourcesForSubId(mContext, subscriptionId);

    }



    private boolean avoidBadWifiCurrentSettings() {

src/com/android/settings/wifi/calling/WifiCallingSettingsForSub.java

+1 −1
Original line number Diff line number Diff line
@@ -639,6 +639,6 @@ public class WifiCallingSettingsForSub extends SettingsPreferenceFragment 


    @VisibleForTesting

    Resources getResourcesForSubId() {

        return SubscriptionManager.getResourcesForSubId(getContext(), mSubId, false);

        return SubscriptionManager.getResourcesForSubId(getContext(), mSubId);

    }

}