Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7bd72f2 authored by Fabrice Di Meglio's avatar Fabrice Di Meglio
Browse files

Fix bug #16533532 Settings app crashes on device orientation change 

...when "change language" warning dialog is on screen

- try harder at getting the parent fragment. First try by calling
getParentFragment() and if this is getting a null reference, try
again by using the fragment Id saved during onSaveInstanceState()

Change-Id: I3dbc6a229224c8770ff2c7e432e76b8796c4b099
parent 9a60d7b5

src/com/android/settings/SettingsPreferenceFragment.java

+3 −0
Original line number Diff line number Diff line
@@ -412,6 +412,9 @@ public class SettingsPreferenceFragment extends PreferenceFragment implements Di 
                mDialogId = savedInstanceState.getInt(KEY_DIALOG_ID, 0);

                mParentFragment = getParentFragment();

                int mParentFragmentId = savedInstanceState.getInt(KEY_PARENT_FRAGMENT_ID, -1);

                if (mParentFragment == null) {

                    mParentFragment = getFragmentManager().findFragmentById(mParentFragmentId);

                }

                if (!(mParentFragment instanceof DialogCreatable)) {

                    throw new IllegalArgumentException(

                            (mParentFragment != null