Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac6c49d2 authored by Hansong Zhang's avatar Hansong Zhang
Browse files

DO NOT MERGE Fix unexpected behavior in Bluetooth pairing 

* Set default PBAP permission to false
* Remove all newline and tab characters in Bluetooth device name

Bug: 72872376
Bug: 73173182
Test: manual
Change-Id: I85f5f11c5803c3031bf9a56273c30c3ef305f63d
parent 0a7ae11c

src/com/android/settings/bluetooth/BluetoothPairingDialog.java

+4 −2
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ import android.text.InputFilter; 
import android.text.InputType;

import android.text.TextWatcher;

import android.text.InputFilter.LengthFilter;

import android.util.EventLog;

import android.util.Log;

import android.view.View;

import android.widget.Button;
@@ -197,8 +198,9 @@ public final class BluetoothPairingDialog extends AlertActivity implements 
        } else {

            if (mDevice.getBluetoothClass().getDeviceClass()

                    == BluetoothClass.Device.AUDIO_VIDEO_HANDSFREE) {

                contactSharing.setChecked(true);

                mDevice.setPhonebookAccessPermission(BluetoothDevice.ACCESS_ALLOWED);

                contactSharing.setChecked(false);

                mDevice.setPhonebookAccessPermission(BluetoothDevice.ACCESS_REJECTED);

                EventLog.writeEvent(0x534e4554, "73173182", -1, "");

            } else {

                contactSharing.setChecked(false);

                mDevice.setPhonebookAccessPermission(BluetoothDevice.ACCESS_REJECTED);

src/com/android/settings/bluetooth/BluetoothPermissionActivity.java

+6 −1
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ import android.content.Intent; 
import android.content.IntentFilter;

import android.os.Bundle;

import android.preference.Preference;

import android.util.EventLog;

import android.util.Log;

import android.view.View;

import android.widget.TextView;
@@ -154,7 +155,11 @@ public class BluetoothPermissionActivity extends AlertActivity implements 
        String mRemoteName = mDevice != null ? mDevice.getAliasName() : null;



        if (mRemoteName == null) mRemoteName = getString(R.string.unknown);

        return mRemoteName;

        String nameNoNewline = mRemoteName.replaceAll("[\\t\\n\\r]+", " ");

        if (!mRemoteName.equals(nameNoNewline)) {

            EventLog.writeEvent(0x534e4554, "72872376", -1, "");

        }

        return nameNoNewline;

    }



    // TODO(edjee): createConnectionDialogView, createPhonebookDialogView and createMapDialogView