Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f74807e authored by Daniel Hunt's avatar Daniel Hunt Committed by Ed Savage-Jones
Browse files

Catch crash in mobile network ProgressDialog 

When enabling "Automatically select network" in "Settings -> Network &
internet -> Mobile network -> Advanced" and rotating the device while
the dialog is showing there will be an IllegalArgumentException since
the decorView isn't attached to the window when dismissing the dialog.
Fixed by simply catching the exception since the dialog will be gone
anyway.

Bug: 146057372
Test: manual (see comment above)
Change-Id: I15f1d6f505fdf33964ce973ece31d6aa0d8f3909
parent e4ad1039

src/com/android/settings/network/telephony/gsm/AutoSelectPreferenceController.java

+5 −1
Original line number Diff line number Diff line
@@ -176,7 +176,11 @@ public class AutoSelectPreferenceController extends TelephonyTogglePreferenceCon 


    private void dismissProgressBar() {

        if (mProgressDialog != null && mProgressDialog.isShowing()) {

            try {

                mProgressDialog.dismiss();

            } catch (IllegalArgumentException e) {

                // Ignore exception since the dialog will be gone anyway.

            }

        }

    }