Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8db6c33b authored by Jacky Wang's avatar Jacky Wang
Browse files

[Catalyst] Avoid PreferenceMetadata.getPreferenceSummary call 

PreferenceMetadata.getPreferenceSummary is implementation detail.

Bug: 388167106
Flag: EXEMPT refactor
Test: atest
Change-Id: I4ec429723f0275c540b4e91e46dfc19fd592c524
parent a7a74821

tests/robotests/src/com/android/settings/accessibility/ColorInversionPreferenceTest.kt

+2 −2
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ class ColorInversionPreferenceTest { 
    fun getSummary_colorInversionOn_verifySummary() {

        SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.ON)



        assertThat(colorInversionPreference.getPreferenceSummary(appContext)).isEqualTo(

        assertThat(colorInversionPreference.getSummary(appContext)).isEqualTo(

            appContext.getText(

                R.string.color_inversion_state_on

            )
@@ -108,7 +108,7 @@ class ColorInversionPreferenceTest { 
    fun getSummary_colorInversionOff_verifySummary() {

        SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.OFF)



        assertThat(colorInversionPreference.getPreferenceSummary(appContext)).isEqualTo(

        assertThat(colorInversionPreference.getSummary(appContext)).isEqualTo(

            appContext.getText(

                R.string.color_inversion_state_off

            )

tests/robotests/src/com/android/settings/accessibility/DaltonizerPreferenceTest.kt

+2 −2
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ class DaltonizerPreferenceTest { 
    fun getSummary_daltonizerOn_verifySummary() {

        SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.ON)



        assertThat(daltonizerPreference.getPreferenceSummary(appContext)).isEqualTo(

        assertThat(daltonizerPreference.getSummary(appContext)).isEqualTo(

            appContext.getText(

                R.string.daltonizer_state_on

            )
@@ -108,7 +108,7 @@ class DaltonizerPreferenceTest { 
    fun getSummary_daltonizerOff_verifySummary() {

        SettingsSecureStore.get(appContext).setInt(SETTING_KEY, AccessibilityUtil.State.OFF)



        assertThat(daltonizerPreference.getPreferenceSummary(appContext)).isEqualTo(

        assertThat(daltonizerPreference.getSummary(appContext)).isEqualTo(

            appContext.getText(

                R.string.daltonizer_state_off

            )

tests/robotests/src/com/android/settings/supervision/SupervisionPinManagementScreenTest.kt

+3 −2
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.settings.supervision 
import android.content.Context

import androidx.test.core.app.ApplicationProvider

import androidx.test.ext.junit.runners.AndroidJUnit4

import com.android.settings.R

import com.google.common.truth.Truth.assertThat

import org.junit.Test

import org.junit.runner.RunWith
@@ -41,7 +42,7 @@ class SupervisionPinManagementScreenTest { 


    @Test

    fun getSummary_addPin() {

        assertThat(supervisionPinManagementScreen.getPreferenceSummary(context))

            .isEqualTo("Add a PIN recovery method")

        assertThat(supervisionPinManagementScreen.summary)

            .isEqualTo(R.string.supervision_pin_management_preference_summary_add)

    }

}