Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 868eb641 authored by Yanting Yang's avatar Yanting Yang
Browse files

Fix divider missing with AppButtonsPreference 

Symptom:
The divider below of the AppButtonsPreference is missing on the
Storage & cache and Battery pages of app.

Root cause:
The PreferenceCategory divider has been hidden for Android S design.
If we put the AppButtonsPreference and the PreferenceCategory together,
the divider will be default hidden by PreferenceCategory.

Solution:
To add back the divider for AppButtonsPreference, override the
allowDividerAbove in the PreferenceCategory.

Fixes: 179118594
Test: visual
Change-Id: I74ba7679a69a578a87734b9920f53a20c79d6567
parent ba8f1ad0

res/xml/app_storage_settings.xml

+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ 
    <PreferenceCategory

        android:key="storage_category"

        android:title="@string/app_info_storage_title"

        settings:allowDividerBelow="false">

        settings:allowDividerAbove="true">



        <Preference

            android:key="app_size"

res/xml/power_usage_detail.xml

+2 −1
Original line number Diff line number Diff line
@@ -31,7 +31,8 @@ 
        android:order="-9999"/>



    <PreferenceCategory

        android:title="@string/battery_detail_manage_title">

        android:title="@string/battery_detail_manage_title"

        settings:allowDividerAbove="true">



        <com.android.settingslib.RestrictedPreference

            android:key="background_activity"