Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a12cd51 authored by menghanli's avatar menghanli
Browse files

Fix flake issue on SettingsRoboTests 

Root cause: SpannableStringBuilder cannot handle the preference title is
empty caes.
Solution: Assign default value in test case setup.

Bug: 188448957
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=AccessibilityButtonFooterPreferenceControllerTest
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=AccessibilityControlTimeoutFooterPreferenceControllerTest
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=CaptionFooterPreferenceControllerTest
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleAutoclickFooterPreferenceControllerTest
Change-Id: Ia95a6ecba824d81e0ccf649975517231ecf475b3
parent cbb2bd6d

tests/robotests/src/com/android/settings/accessibility/AccessibilityButtonFooterPreferenceControllerTest.java

+2 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner; 
public class AccessibilityButtonFooterPreferenceControllerTest {



    private static final String TEST_KEY = "test_key";

    private static final String TEST_TITLE = "test_title";

    private final Context mContext = ApplicationProvider.getApplicationContext();

    private PreferenceScreen mScreen;

    private AccessibilityButtonFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class AccessibilityButtonFooterPreferenceControllerTest { 
        final AccessibilityFooterPreference footerPreference =

                new AccessibilityFooterPreference(mContext);

        footerPreference.setKey(TEST_KEY);

        footerPreference.setTitle(TEST_TITLE);

        mScreen.addPreference(footerPreference);

        mController = new AccessibilityButtonFooterPreferenceController(mContext, TEST_KEY);

    }

tests/robotests/src/com/android/settings/accessibility/AccessibilityControlTimeoutFooterPreferenceControllerTest.java

+2 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner; 
public class AccessibilityControlTimeoutFooterPreferenceControllerTest {



    private static final String TEST_KEY = "test_key";

    private static final String TEST_TITLE = "test_title";

    private final Context mContext = ApplicationProvider.getApplicationContext();

    private PreferenceScreen mScreen;

    private AccessibilityControlTimeoutFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class AccessibilityControlTimeoutFooterPreferenceControllerTest { 
        final AccessibilityFooterPreference footerPreference =

                new AccessibilityFooterPreference(mContext);

        footerPreference.setKey(TEST_KEY);

        footerPreference.setTitle(TEST_TITLE);

        mScreen.addPreference(footerPreference);

        mController = new AccessibilityControlTimeoutFooterPreferenceController(mContext, TEST_KEY);

    }

tests/robotests/src/com/android/settings/accessibility/CaptionFooterPreferenceControllerTest.java

+2 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner; 
public class CaptionFooterPreferenceControllerTest {



    private static final String TEST_KEY = "test_key";

    private static final String TEST_TITLE = "test_title";

    private final Context mContext = ApplicationProvider.getApplicationContext();

    private PreferenceScreen mScreen;

    private CaptionFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class CaptionFooterPreferenceControllerTest { 
        final AccessibilityFooterPreference footerPreference =

                new AccessibilityFooterPreference(mContext);

        footerPreference.setKey(TEST_KEY);

        footerPreference.setTitle(TEST_TITLE);

        mScreen.addPreference(footerPreference);

        mController = new CaptionFooterPreferenceController(mContext, TEST_KEY);

    }

tests/robotests/src/com/android/settings/accessibility/ToggleAutoclickFooterPreferenceControllerTest.java

+2 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ import org.robolectric.RobolectricTestRunner; 
public class ToggleAutoclickFooterPreferenceControllerTest {



    private static final String TEST_KEY = "test_key";

    private static final String TEST_TITLE = "test_title";

    private final Context mContext = ApplicationProvider.getApplicationContext();

    private PreferenceScreen mScreen;

    private ToggleAutoclickFooterPreferenceController mController;
@@ -47,6 +48,7 @@ public class ToggleAutoclickFooterPreferenceControllerTest { 
        final AccessibilityFooterPreference footerPreference =

                new AccessibilityFooterPreference(mContext);

        footerPreference.setKey(TEST_KEY);

        footerPreference.setTitle(TEST_TITLE);

        mScreen.addPreference(footerPreference);

        mController = new ToggleAutoclickFooterPreferenceController(mContext, TEST_KEY);

    }