Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f42eb20 authored by ykhung's avatar ykhung Committed by YK Hung
Browse files

Remove the legacy smart battery tip from Settings 

Remove the legacy smart battery tip from the battery settings, which
will remind users to eanble the "adaptive battery" if users disable it.

Reasons: 1) 98% users will always keep the AB is enabled, and 2) we move
the AB into the battery saver page, there is no individual page anymore

Fix: 281798483
Test: make test RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.fuelgauge.batterytip.*
Change-Id: I85739b88ee9373b95a62271d2eb0137cf411d8cb
parent f5a34853

src/com/android/settings/fuelgauge/batterytip/BatteryTipLoader.java

+0 −3
Original line number Diff line number Diff line
@@ -67,9 +67,6 @@ public class BatteryTipLoader extends AsyncLoaderCompat<List<BatteryTip>> { 


        tips.add(new LowBatteryDetector(context, policy, batteryInfo, isPowerSaveMode).detect());

        tips.add(new HighUsageDetector(context, policy, mBatteryUsageStats, batteryInfo).detect());

        tips.add(new SmartBatteryDetector(

                context, policy, batteryInfo, context.getContentResolver(), isPowerSaveMode)

                        .detect());

        tips.add(new BatteryDefenderDetector(batteryInfo, context).detect());

        tips.add(new DockDefenderDetector(batteryInfo, context).detect());

        tips.add(new IncompatibleChargerDetector(context).detect());

tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryTipLoaderTest.java

+1 −2
Original line number Diff line number Diff line
@@ -54,8 +54,7 @@ public class BatteryTipLoaderTest { 
            BatteryTip.TipType.BATTERY_DEFENDER,

            BatteryTip.TipType.DOCK_DEFENDER,

            BatteryTip.TipType.INCOMPATIBLE_CHARGER,

            BatteryTip.TipType.HIGH_DEVICE_USAGE,

            BatteryTip.TipType.SMART_BATTERY_MANAGER};

            BatteryTip.TipType.HIGH_DEVICE_USAGE};

    @Mock(answer = Answers.RETURNS_DEEP_STUBS)

    private BatteryUsageStats mBatteryUsageStats;

    @Mock