Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2efec86b authored by Antony Sargent's avatar Antony Sargent
Browse files

Get rid of spurious gear icon in BT details page 

The problem is that we were calling done() on the EntityHeaderController
and passing false for whether to rebind the action buttons, which means
we were getting the default behavior including a visible gear
icon. Passing true to request rebinding causes that icon to be hidden.

Bug: 63405635
Test: make RunSettingsRoboTests
Change-Id: I031f4a2d176ff3be025cc2675d7026a679936b03
parent 6d505764

src/com/android/settings/bluetooth/BluetoothDetailsHeaderController.java

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ public class BluetoothDetailsHeaderController extends BluetoothDetailsController 
    @Override

    protected void refresh() {

        setHeaderProperties();

        mHeaderController.done(mFragment.getActivity(), false);

        mHeaderController.done(mFragment.getActivity(), true /* rebindActions */);

    }



    @Override

tests/robotests/src/com/android/settings/bluetooth/BluetoothDetailsHeaderControllerTest.java

+1 −1
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ public class BluetoothDetailsHeaderControllerTest extends BluetoothDetailsContro 
        verify(mHeaderController).setIcon(any(Drawable.class));

        verify(mHeaderController).setIconContentDescription(any(String.class));

        verify(mHeaderController).setSummary(any(String.class));

        verify(mHeaderController).done(mActivity, false);

        verify(mHeaderController).done(mActivity, true);

    }



    @Test