Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix: button text is not vertically centered

Ivan Baheux requested to merge 8765-a15-vertically-align-buttons into a15

Description

When the text sizes are too large, the values in the landcape input pad tend to be too large and not centered in the button. We fix this by limiting the max size that a text can get to.

Screenshots

Before fixes After fixes

Technical details

Simply make use of autoSize instead of relying on the size growing automatically. We could also have limited the size via the code and not the xml but I thought that our solution was simpler.

Tests

Tested minimum, default and max size. Checked portrait mode too, no change was visible (did not put the screenshots for readability).

Issues

Solves issue 8765 for a15

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Merge request reports

Loading