Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Fix dark mode colour issues in Pie

Fahim Salam Chowdhury requested to merge Pie_2826 into v1-pie

Description

Fix colour compatibility issue in the OS dark-mode. Calculator's advance pad, History Page's `clear` action List item, license page background were not switching to respected dark-colour when user select dark mode. Also replace `color_default_blue1` colour code with `color_default_accent`.

Dependencies required:

Home page

portrait portrait landscape
Screenshot_20210409-000230_Calculator Screenshot_20210409-000241_Calculator Screenshot_20210409-000305_Calculator

History page

portrait landscape
Screenshot_20210409-000325_Calculator Screenshot_20210409-000338_Calculator

License page

portrait landscape
Screenshot_20210409-000404_Calculator Screenshot_20210409-000410_Calculator

Related issues

- 2868

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Related MRs

- 14

How has this been tested?

  • build the apk using build->CI/CD pipeline with FEATURE_BRANCH = Pie_2826
  • push the apk to beryllium device's /system/app/ExactCalculator/
  • run the apk on OS's dark mode enable

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Merge request reports