Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix: update LoginActivity intent to launch AccountManager instead of DAVx5 client

Fahim Masud Choudhury requested to merge 6523-t-calendar-davx5-cherry-picked into v1-t

Description

While trying to add a CalDAV calendar, users were previously redirected to DAVx5 client app, instead of /e/OS's AccountManager. This MR fixes the issue by navigating the user to the AccountManager app to log in to Murena cloud.

Screenshots

image.pngimage.png

Technical details

The ClassName of the intent to open the LoginActivity is set to /e/OS's AccountManager, instead of DAVx5 client's app. If there was no DAVx5 client found on the device, App Lounge showed the Google Play version of the app.

Inside App Lounge, if “Show common apps” setting was unchecked, then users were prompted to log in (Google/Anonymous) and try installing the app again.

Tests

Manual tests have been performed to see if users are correctly navigated to AccountManager app.

Issues

e/backlog#6523 (closed)

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

  • New Features
    • Updated the integration for launching the DavX5 login activity, enhancing compatibility with new application architecture.
  • Bug Fixes
    • Ensured the application still checks and attempts to start the login activity if available.
Edited by Fahim Masud Choudhury

Merge request reports

Loading