Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fix: Improve Calendar's monthly view UI [v1-s]

Fahim Masud Choudhury requested to merge 7012-s-fix-calendar-ui-regression into v1-s

Description

The monthly view of the calendar had several UI issues:

  • The day names were not centered horizontally
  • The day numbers were not centered horizontally inside each cell
  • The circle around today's date was not aligned with the date

This MR fixes the UI issues adhering to the Figma design.

Screenshots

Monthly view with and without week numbers.

Before

Screenshot_20240122_140444_before_v1-t Screenshot_20240122_140521_before_v1-t_week_num

After

image image

Tests

Manual tests comparing before and after versions with the Figma designs have been performed.

Issues

GitLab issue: e/backlog#7012 (closed)

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Fahim Masud Choudhury

Merge request reports