Commit dfc30280 authored Feb 28, 2025 by Ben Reich

Fix RenameDocumentUiTest#testRenameFile_OkButton

For some reason the onView().perform() logic that is present in the
clickDialogOkButton is not clicking the actual button. This is
leading to the test just dismissing the dialog instead of
actioning it. Instead let's update it to use UiObject2 and perform
the click, this seems more stable across Android versions.

Bug: 394151244
Bug: 384582399
Test: atest RenameDocumentUiTest#testRenameFile_OkButton
Flag: EXEMPT Test fix
Change-Id: I6535a023b66506e363d03b121abb60e6b08c5070

parent 9d04a405

tests/common/com/android/documentsui/bots/UiBot.java

+2 −1

Original line number	Diff line number	Diff line
		@@ -284,7 +284,8 @@ public class UiBot extends Bots.BaseBot {
		// Espresso has flaky results when keyboard shows up, so hiding it for now
		// before trying to click on any dialog button
		Espresso.closeSoftKeyboard();
		onView(withId(android.R.id.button1)).perform(click());
		UiObject2 okButton = mDevice.findObject(By.res("android:id/button1"));
		okButton.click();
		}

		public void clickDialogCancelButton() throws UiObjectNotFoundException {