Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc1ae454 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Remove "Compress To"."

parents 69c03e85 49cd92dd
Loading
Loading
Loading
Loading
+0 −5
Original line number Diff line number Diff line
@@ -50,11 +50,6 @@
        android:title="@string/menu_move"
        android:showAsAction="never"
        android:visible="false" />
    <item
        android:id="@+id/menu_compress_to"
        android:title="@string/menu_compress_to"
        android:showAsAction="never"
        android:visible="false" />
    <item
        android:id="@+id/menu_compress"
        android:title="@string/menu_compress"
+0 −2
Original line number Diff line number Diff line
@@ -52,8 +52,6 @@
    <string name="menu_copy">Copy to\u2026</string>
    <!-- Menu item title that moves the selected documents [CHAR LIMIT=28] -->
    <string name="menu_move">Move to\u2026</string>
    <!-- Menu item title that compresses the selected documents to the user selected directory [CHAR LIMIT=28] -->
    <string name="menu_compress_to">Compress to\u2026</string>
    <!-- Menu item title that compresses the selected documents to the current directory [CHAR LIMIT=28] -->
    <string name="menu_compress">Compress</string>
    <!-- Menu item title that extracts the selected documents [CHAR LIMIT=28] -->
+0 −5
Original line number Diff line number Diff line
@@ -60,7 +60,6 @@ public abstract class MenuManager {
        updateSelectAll(menu.findItem(R.id.menu_select_all));
        updateMoveTo(menu.findItem(R.id.menu_move_to), selection);
        updateCopyTo(menu.findItem(R.id.menu_copy_to), selection);
        updateCompressTo(menu.findItem(R.id.menu_compress_to), selection);
        updateCompress(menu.findItem(R.id.menu_compress), selection);
        updateExtractTo(menu.findItem(R.id.menu_extract_to), selection);

@@ -272,10 +271,6 @@ public abstract class MenuManager {
        copyTo.setVisible(false);
    }

    protected void updateCompressTo(MenuItem compressTo, SelectionDetails selectionDetails) {
        compressTo.setVisible(false);
    }

    protected void updateCompress(MenuItem compress, SelectionDetails selectionDetails) {
        compress.setVisible(false);
    }
+2 −2
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ public final class Metrics {
    public static final int USER_ACTION_HIDE_SIZE = 9;
    public static final int USER_ACTION_SETTINGS = 10;
    public static final int USER_ACTION_COPY_TO = 11;
    public static final int USER_ACTION_COMPRESS_TO = 27;
    public static final int USER_ACTION_COMPRESS = 27;
    public static final int USER_ACTION_EXTRACT_TO = 28;
    public static final int USER_ACTION_MOVE_TO = 12;
    public static final int USER_ACTION_DELETE = 13;
@@ -335,7 +335,7 @@ public final class Metrics {
            USER_ACTION_HIDE_SIZE,
            USER_ACTION_SETTINGS,
            USER_ACTION_COPY_TO,
            USER_ACTION_COMPRESS_TO,
            USER_ACTION_COMPRESS,
            USER_ACTION_EXTRACT_TO,
            USER_ACTION_MOVE_TO,
            USER_ACTION_DELETE,
+1 −8
Original line number Diff line number Diff line
@@ -629,13 +629,6 @@ public class DirectoryFragment extends Fragment
                mActionModeController.finishActionMode();
                return true;

            case R.id.menu_compress_to:
                transferDocuments(selection, null, FileOperationService.OPERATION_COMPRESS);
                // TODO: Only finish selection mode if compress-to is not canceled.
                // Need to plum down into handling the way we do with deleteDocuments.
                mActionModeController.finishActionMode();
                return true;

            // TODO: Implement extract (to the current directory).
            case R.id.menu_extract_to:
                transferDocuments(selection, null, FileOperationService.OPERATION_EXTRACT);
@@ -738,7 +731,7 @@ public class DirectoryFragment extends Fragment
                Metrics.logUserAction(getContext(), Metrics.USER_ACTION_COPY_TO);
                break;
            case FileOperationService.OPERATION_COMPRESS:
                Metrics.logUserAction(getContext(), Metrics.USER_ACTION_COMPRESS_TO);
                Metrics.logUserAction(getContext(), Metrics.USER_ACTION_COMPRESS);
                break;
            case FileOperationService.OPERATION_EXTRACT:
                Metrics.logUserAction(getContext(), Metrics.USER_ACTION_EXTRACT_TO);
Loading