Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3aa3fb5e authored by Colin Cross's avatar Colin Cross
Browse files

Fix Error Prone errors

Soong wasn't including android_app or android_test sources in the
javac-check target used for the Error Prone build, which allowed
some Error Prone errors to get in.  Fix them so Error Prone can be
re-enabled for these targets.

Fixes:
packages/apps/DocumentsUI/tests/unit/com/android/documentsui/base/StateTest.java:92: error: [JUnit4TestNotRun] This looks like a test method but is not run; please add @Test and @Ignore, or, if this is a helper method, reduce its visibility.

Bug: 146455923
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Ifdc8b7c0dd6dced463cf6b2c29f0abc23326a0bd
parent 47454c56
Loading
Loading
Loading
Loading
+4 −1
Original line number Diff line number Diff line
@@ -89,8 +89,11 @@ public class StateTest {
        assertTrue(mState.shouldShowPreview());
    }

    @Test
    public void testPhotoPicking_onlyOneImageType() {
        mIntent.putExtra(Intent.EXTRA_MIME_TYPES, MIME_TYPES[0]);
        String[] stringArray = { MIME_TYPES[0] };
        mIntent.putExtra(Intent.EXTRA_MIME_TYPES, stringArray);

        mState.initAcceptMimes(mIntent, "*/*");
        mState.action = State.ACTION_GET_CONTENT;