Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2edfd23a authored by Colin Cross's avatar Colin Cross
Browse files

Remove @SortDimensionId 

The sort dimension ID can't be an @IntDef because the values are not
constant when DocumentsUI is compiled as a library so that it can be
compiled once for DocumentsUI and DocumentsUIGoogle.

This relands Ie6ddc3869c6f758b75a048a2e5fe2e0dc9305424.

Bug: 294256649
Test: m DocumentsUI
Change-Id: I5f7c7c2ac90fb852e7de47299b159f2fe71ca76a
parent d3de7985

src/com/android/documentsui/sorting/SortListFragment.java

+2 −3
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ import androidx.fragment.app.FragmentManager; 


import com.android.documentsui.R;

import com.android.documentsui.sorting.SortDimension.SortDirection;

import com.android.documentsui.sorting.SortModel.SortDimensionId;



import com.google.android.material.bottomsheet.BottomSheetBehavior;

import com.google.android.material.bottomsheet.BottomSheetDialog;
@@ -170,7 +169,7 @@ public class SortListFragment extends DialogFragment { 


    private static class SortItem {



        @SortDimensionId final int id;

        final int id;

        @SortDirection final int direction;

        @StringRes final int labelId;
@@ -180,7 +179,7 @@ public class SortListFragment extends DialogFragment { 
            labelId = dimension.getLabelId();

        }



        SortItem(@SortDimensionId int id, @SortDirection int direction, @StringRes int labelId) {

        SortItem(int id, @SortDirection int direction, @StringRes int labelId) {

            this.id = id;

            this.direction = direction;

            this.labelId = labelId;

src/com/android/documentsui/sorting/SortModel.java

+0 −10
Original line number Diff line number Diff line
@@ -47,16 +47,6 @@ import java.util.function.Consumer; 
 * Sort model that contains all columns and their sorting state.

 */

public class SortModel implements Parcelable {

    @IntDef({

            SORT_DIMENSION_ID_UNKNOWN,

            SORT_DIMENSION_ID_TITLE,

            SORT_DIMENSION_ID_SUMMARY,

            SORT_DIMENSION_ID_SIZE,

            SORT_DIMENSION_ID_FILE_TYPE,

            SORT_DIMENSION_ID_DATE

    })

    @Retention(RetentionPolicy.SOURCE)

    public @interface SortDimensionId {}

    public static final int SORT_DIMENSION_ID_UNKNOWN = 0;

    public static final int SORT_DIMENSION_ID_TITLE = android.R.id.title;

    public static final int SORT_DIMENSION_ID_SUMMARY = android.R.id.summary;

src/com/android/documentsui/sorting/SortingCursorWrapper.java

+1 −2
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ import android.provider.DocumentsContract.Document; 


import com.android.documentsui.base.Lookup;

import com.android.documentsui.base.Shared;

import com.android.documentsui.sorting.SortModel.SortDimensionId;



/**

 * Cursor wrapper that presents a sorted view of the underlying cursor. Handles
@@ -49,7 +48,7 @@ class SortingCursorWrapper extends AbstractCursor { 
        long[] longValues = null;

        String[] ids = new String[count];



        final @SortDimensionId int id = dimension.getId();

        final int id = dimension.getId();

        switch (id) {

            case SortModel.SORT_DIMENSION_ID_TITLE:

            case SortModel.SORT_DIMENSION_ID_FILE_TYPE:

src/com/android/documentsui/sorting/TableHeaderController.java

+1 −2
Original line number Diff line number Diff line
@@ -19,7 +19,6 @@ package com.android.documentsui.sorting; 
import android.view.View;



import com.android.documentsui.R;

import com.android.documentsui.sorting.SortModel.SortDimensionId;



import javax.annotation.Nullable;
@@ -78,7 +77,7 @@ public final class TableHeaderController implements SortController.WidgetControl 
        mModel.removeListener(mModelListener);

    }



    private void bindCell(HeaderCell cell, @SortDimensionId int id) {

    private void bindCell(HeaderCell cell, int id) {

        assert(cell != null);

        SortDimension dimension = mModel.getDimensionById(id);

tests/common/com/android/documentsui/bots/SortBot.java

+2 −3
Original line number Diff line number Diff line
@@ -45,7 +45,6 @@ import com.android.documentsui.sorting.SortDimension; 
import com.android.documentsui.sorting.SortDimension.SortDirection;

import com.android.documentsui.sorting.SortListFragment;

import com.android.documentsui.sorting.SortModel;

import com.android.documentsui.sorting.SortModel.SortDimensionId;



import org.hamcrest.Matcher;
@@ -67,7 +66,7 @@ public class SortBot extends Bots.BaseBot { 
        mUiBot = uiBot;

    }



    public void sortBy(@SortDimensionId int id, @SortDirection int direction) {

    public void sortBy(int id, @SortDirection int direction) {

        assert(direction != SortDimension.SORT_DIRECTION_NONE);



        final @StringRes int labelId = mSortModel.getDimensionById(id).getLabelId();
@@ -102,7 +101,7 @@ public class SortBot extends Bots.BaseBot { 
        assertTrue(Matchers.present(mColumnBot.MATCHER));

    }



    private boolean sortByMenu(@SortDimensionId int id, @SortDirection int direction) {

    private boolean sortByMenu(int id, @SortDirection int direction) {

        assert(direction != SortDimension.SORT_DIRECTION_NONE);



        clickMenuSort();