Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3de7985 authored by Treehugger Robot's avatar Treehugger Robot Committed by Android (Google) Code Review
Browse files

Merge changes from topic "revert-25032702-DocumentsUI-lib-ISIBQCUCRZ" into main

* changes:
  Revert "Remove @SortDimensionId"
  Revert "Change switches on resource IDs to if statements"
  Revert "Build DocumentsUI sources once"
parents 9868d7c9 020f01ce
Loading
Loading
Loading
Loading
+54 −8
Original line number Diff line number Diff line
@@ -68,6 +68,14 @@ platform_compat_config {
    src: ":DocumentsUI",
}

filegroup {
    name: "DocumentsUI-srcs",
    srcs: [
        "src/**/*.java",
	":statslog-docsui-java-gen",
    ],
}

java_library {
    name: "docsui-statsd",
    srcs: [
@@ -85,18 +93,51 @@ genrule {
}

android_library {
    name: "DocumentsUI-lib",
    defaults: ["documentsui_defaults"],
    name: "DocumentsUI-res-lib",

    manifest: "AndroidManifest.xml",

    manifest: "AndroidManifestLib.xml",
    static_libs: [
        "androidx.appcompat_appcompat",
        "com.google.android.material_material",
    ],

    resource_dirs: [
        "res",
    ],

    srcs: [
        "src/**/*.java",
	":statslog-docsui-java-gen",
    aaptflags: [
        "--auto-add-overlay",
    ],

    sdk_version: "system_current",
    target_sdk_version: "33",
    min_sdk_version: "29",
    lint: { strict_updatability_linting: true }
}

android_library {
    name: "DocumentsUIUnitTests-res-lib",

    manifest: "AndroidManifestForUnitTests.xml",

    static_libs: [
        "androidx.appcompat_appcompat",
        "com.google.android.material_material",
        "modules-utils-build_system",
    ],

    resource_dirs: [
        "res",
    ],

    licenses: [
        "Android-Apache-2.0",
        "packages_apps_DocumentsUI_res_drawable_pd_license",
    ],

    aaptflags: [
        "--auto-add-overlay",
    ],

    sdk_version: "system_current",
@@ -112,8 +153,13 @@ android_app {

    manifest: "AndroidManifest.xml",

    static_libs: ["DocumentsUI-lib"],
    resource_dirs: [],
    srcs: [
        ":DocumentsUI-srcs",
    ],

    resource_dirs: [
        "res",
    ],

    licenses: [
        "Android-Apache-2.0",
+0 −0

File moved.

+1 −1
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ android_test {
    manifest: "AndroidManifest.xml",

    srcs: [
        ":DocumentsUIPerfTests-files",
        "src/**/*.java",
    ],

@@ -22,7 +23,6 @@ android_test {
    ],

    static_libs: [
        "DocumentsUIPerfTests-lib",
        "androidx.legacy_legacy-support-v4",
        "androidx.test.rules",
        "androidx.test.espresso.core",
+1 −2
Original line number Diff line number Diff line
@@ -79,8 +79,7 @@ public class ActionModeController extends SelectionObserver<String>
                    Log.d(TAG, "Starting action mode.");
                }
                mActionMode = mActivity.startActionMode(this);
                final View closeButton =
                        mActivity.findViewById(androidx.appcompat.R.id.action_mode_close_button);
                final View closeButton = mActivity.findViewById(R.id.action_mode_close_button);
                if (closeButton != null) {
                    closeButton.setContentDescription(mActivity.getString(android.R.string.cancel));
                }
+44 −32
Original line number Diff line number Diff line
@@ -75,6 +75,7 @@ import com.android.documentsui.sidebar.RootsFragment;
import com.android.documentsui.sorting.SortController;
import com.android.documentsui.sorting.SortModel;

import com.android.documentsui.util.VersionUtils;
import com.google.android.material.appbar.AppBarLayout;

import java.util.ArrayList;
@@ -503,40 +504,51 @@ public abstract class BaseActivity
    @Override
    public boolean onOptionsItemSelected(MenuItem item) {

        final int id = item.getItemId();
        if (id == android.R.id.home) {
        switch (item.getItemId()) {
            case android.R.id.home:
                onBackPressed();
                return true;
        } else if (id == R.id.option_menu_create_dir) {

            case R.id.option_menu_create_dir:
                getInjector().actions.showCreateDirectoryDialog();
                return true;
        } else if (id == R.id.option_menu_search) {

            case R.id.option_menu_search:
                // SearchViewManager listens for this directly.
                return false;
        } else if (id == R.id.option_menu_select_all) {

            case R.id.option_menu_select_all:
                getInjector().actions.selectAllFiles();
                return true;
        } else if (id == R.id.option_menu_debug) {

            case R.id.option_menu_debug:
                getInjector().actions.showDebugMessage();
                return true;
        } else if (id == R.id.option_menu_sort) {

            case R.id.option_menu_sort:
                getInjector().actions.showSortDialog();
                return true;
        } else if (id == R.id.option_menu_launcher) {

            case R.id.option_menu_launcher:
                getInjector().actions.switchLauncherIcon();
                return true;
        } else if (id == R.id.option_menu_show_hidden_files) {

            case R.id.option_menu_show_hidden_files:
                onClickedShowHiddenFiles();
                return true;
        } else if (id == R.id.sub_menu_grid) {
            setViewMode(MODE_GRID);

            case R.id.sub_menu_grid:
                setViewMode(State.MODE_GRID);
                return true;
        } else if (id == R.id.sub_menu_list) {

            case R.id.sub_menu_list:
                setViewMode(State.MODE_LIST);
                return true;
        }

            default:
                return super.onOptionsItemSelected(item);
        }
    }

    protected final @Nullable DirectoryFragment getDirectoryFragment() {
        return DirectoryFragment.get(getSupportFragmentManager());
Loading