Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7fda6fe authored by Tyler Gunn's avatar Tyler Gunn
Browse files

Fixing Null Pointer exception due to uninitialized view reference.

Bug indicates a crash occurred when trying to separate a call from a
conference call.  The exception thrown was due to calling "setText" on
mSecondaryCallProviderLabel when it was null.

Although I was not able to reproduce this situation, it appears it would
be possible for showAndInitializeSecondaryCallInfo to not set the
mSecondaryCallProviderLabel reference when then mSecondaryCallName is
initially set if the hasProvider flag is false at the time.  If
hasProvider becomes true in the future since mSecondaryCallName is already
initialized, the code to initialize mSecondaryCallProviderLabel would not
run, causing the NPE.

I have restructured the code to ensure that this type of scenario is
handled appropriately.

Bug: 18917883
Change-Id: I837d96aad7ed98729490d95beb897b08e1b08365
parent 6a918d7c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment