Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit ce5ad9c8 authored by sail's avatar sail Committed by Eric Erfanian
Browse files

Automated g4 rollback of changelist 160696979.

*** Reason for rollback ***

Causes crash on launch (b/63252565)

*** Original change description ***

Fix concurrency issue in constructor.

Before:
sColors served as the branch to initialize all member variables.

Subsequent calls to the constructor after sColors had been initialized,
would result in the use of static members that were not yet initialized.

Now:
We guard each reference with an explicit null check during construct.

Members that require synchronized initialization were put into a small synchronized
method.

This was chosen instead of AtomicReferences, and instead of double check...

***

Bug: 63143138
Test: N/A
PiperOrigin-RevId: 160837963
Change-Id: I2586f7586c8f39182d64c3b28a59886c5ba94789
parent 115a7c9b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment