Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7c7884f authored by Arvind Mukund's avatar Arvind Mukund Committed by Gerrit Code Review
Browse files

Delete failed CallRecording file 



Created CallRecording file isn't deleted when CallRecording fails. This
results in an empty file. Try deleting this file, if an error occurs.

Change-Id: Ia3a75c3575a6efe7aea12cbf6c110f20601519e7
Signed-off-by: default avatarArvind Mukund <armu30@gmail.com>
parent 79c899df

src/com/android/services/callrecorder/CallRecorderService.java

+6 −0
Original line number Diff line number Diff line
@@ -157,12 +157,18 @@ public class CallRecorderService extends Service { 
            return true;

        } catch (IOException e) {

            Log.w(TAG, "Could not start recording for file " + outputPath, e);

            Log.w(TAG, "Deleting failed recording " + outputPath);

            file.delete();

        } catch (IllegalStateException e) {

            Log.w(TAG, "Could not start recording for file " + outputPath, e);

            Log.w(TAG, "Deleting failed recording " + outputPath);

            file.delete();

        } catch (RuntimeException e) {

            // only catch exceptions thrown by the MediaRecorder JNI code

            if (e.getMessage().indexOf("start failed") >= 0) {

                Log.w(TAG, "Could not start recording for file " + outputPath, e);

                Log.w(TAG, "Deleting failed recording " + outputPath);

                file.delete();

            } else {

                throw e;

            }