This project is mirrored from https://github.com/LineageOS/android_packages_apps_DeskClock.git. Pull mirroring updated .
  1. 19 Apr, 2021 1 commit
  2. 01 Apr, 2021 1 commit
  3. 01 Mar, 2021 1 commit
  4. 15 Dec, 2020 1 commit
  5. 01 Nov, 2020 1 commit
  6. 01 Oct, 2020 1 commit
  7. 20 Sep, 2020 1 commit
  8. 12 Sep, 2020 1 commit
  9. 09 Sep, 2020 2 commits
  10. 23 Jul, 2020 2 commits
    • Raman Tenneti's avatar
      DeskClock: Fix alarm clock screen show black when screen locked; · 67527f30
      Raman Tenneti authored
      Root cause: API ActivityTaskManagerService.notifyKeyguardFlagsChanged is called multiple times,
      which causes the activity status abnormal.
      
      Solution: Add 'android:showWhenLocked = true' to
      ensure activity show on the top even  when screen locked.
      
      BUG: 156311117
      
      Test: manual - Tested the DeskClock UI manually and tested the alarm.
      
      $ make -j 40
      $ ls -l  out/target/product/bonito/product/app/DeskClock/DeskClock.apk
        -rw-r----- 1 rtenneti primarygroup 6117353 Jul 13 11:35 out/target/product/bonito/product/app/DeskClock/DeskClock.apk
      
      $ adb install -r out/target/product/bonito/product/app/DeskClock/DeskClock.apk
      
      + Verified by setting up the alaram, lock the screen and waiting for the alarm to go off.
      
      Change-Id: I69c44571cd86c21203311c89081c8935d5ed1450
      67527f30
    • Raman Tenneti's avatar
      AOSP/DeskClock - Call executePendingTransactions only if mFragmentManager is... · 11b4721b
      Raman Tenneti authored
      AOSP/DeskClock - Call executePendingTransactions only if mFragmentManager is not destroyed. Fixes the crash bug. Code matches internal code.
      
      BUG: 153590150
      
      Test: manual - Tested the DeskClock UI manually and tested the timer.
      
      $ make -j 40
      
      ... 6117353 Jul  7 15:27 out/target/product/bonito/product/app/DeskClock/DeskClock.apk
      
      $ adb install -r -d -t out/target/product/bonito/product/app/DeskClock/DeskClock.apk
      
      Change-Id: I582013ebffef2c8d1ec16255ea531d874d14a968
      11b4721b
  11. 14 Jul, 2020 1 commit
  12. 13 Jul, 2020 4 commits
    • Michael W's avatar
      DeskClock: Fix FAB not being shown everytime · c38683a9
      Michael W authored
      * The getTimer() method returns null when we call getFabTargetVisibility()
        before the onCreateView method gets called, resulting in the FAB not
        being shown
      * A video how to reproduce the issue can be found on the bug report linked
        below
      * Fix: Always return the first timer (if one exists) so we can properly
        decide if the FAB needs to be shown
      
      Fixes: https://gitlab.com/LineageOS/issues/android/-/issues/2250
      Change-Id: Id16686c729ee41d14c890827dc441e81511c8405
      c38683a9
    • Michael Bestas's avatar
      DeskClock: Remove unused imports from NotificationUtils · 8a9bb0c3
      Michael Bestas authored
      Change-Id: I421928b0dae80290bf318a117037c8044a1c7b3b
      8a9bb0c3
    • Michael Bestas's avatar
      DeskClock: Stop depending on platform APIs · 68a451b0
      Michael Bestas authored
      * We can build with sdk_version = current after latest changes
      
      Change-Id: Ie424ffd156e9595082dc8ad935fb1c9e8e22bd87
      68a451b0
    • Michael W's avatar
      DeskClock: Remove references to org.lineageos.platform.internal · 9378f673
      Michael W authored
      * Was used for a feature that isn't used anymore
      * We need to create new tables because dropping columns isn't supported
        -> create temp tables, copy over values, remove old tables, rename temp
           tables
      * Also fixes alarm inserts, which partially failed due to increasing
        volume and profile being indexed wrong:
      "CursorWindow: Failed to read row 0, column 11 from a CursorWindow which
      has 1 rows, 11 columns."
      * Above fix is required for "new Alarms(cursor)" to not fail so we can
        actually get a valid Alarms object to insert into our (temp) database
      
      Change-Id: I80e495792dcb65955de09268c7df9c6846cee559
      9378f673
  13. 12 Jul, 2020 1 commit
    • Michael W's avatar
      DeskClock: Don't rely on framework · 2369e050
      Michael W authored
      * Building within an AOSP environment sets sdk_version: "current"
        which makes the build fail here due to usage of "com.android.internal"
        stuff
      * Set local ids instead where required and use PreferenceImageView
        from androidx instead of com.android.internal
      
      Change-Id: I5b50531720840ae81559c8fd958166154098b782
      2369e050
  14. 21 Jun, 2020 1 commit
  15. 15 Jun, 2020 1 commit
    • Michael W's avatar
      DeskClock: Remove notification sound from firing and snoozing channels · 01c3369e
      Michael W authored
      * Firing alarms and timers needs high priority but we don't need a
        notification sound, as the alarm / timer already bring their own sound
      * This has been lost in the rework of notification channels
        -> Needs another channel recreation
      
      * Snoozing was lowered in priority in commit
        22b6cf2f
        but I didn't give it a new id, so existing installations are left with
        notification sound when snoozing - who would want that?
      
      Change-Id: I5c7fc96b657e966950414b40fb61c829040ece9f
      01c3369e
  16. 14 Jun, 2020 2 commits
    • Michael W's avatar
      DeskClock: Replace ViewPager with manual fragment handling · fbaedef9
      Michael W authored
      * Convert to using androidx Fragments
      * Group imports properly
      
      Change-Id: Iaadfb417f0ca8638936875113ec2f39853f2a39c
      fbaedef9
    • Michael W's avatar
      DeskClock: Fix german translation of "days" · 26df7bf2
      Michael W authored
      * Currently the snackbar says
        "Der Wecker klingelt in 5 Tage, 3 Stunden  und 47 Minuten"
      * It must be "Der Wecker klingelt in 5 Tagen, 3 Stunden und 47 Minuten"
      * Also checked if these plurals aren't used elsewhere so other strings
        wouldn't make sense anymore - no more usages found
      
      Change-Id: Iabadaa254afc7a04cb00d79753be1443719fce2c
      26df7bf2
  17. 12 Jun, 2020 1 commit
    • Michael W's avatar
      DeskClock: Properly align settings · b6bca2fe
      Michael W authored
      * The alarm volume setting doesn't look as it should
      * Copied "preference_volume_slider" from Settings (used in Settings->
        Sound) and stripped by stuff we don't need (suppression_text,
        widget_frame)
      * Looks like without providing an initial icon, the layout would not
        inflate the space for it properly, so provide the default one
      
      Change-Id: I31d103cd0b0a6f096d376af2026702a0a4754671
      b6bca2fe
  18. 11 Jun, 2020 1 commit
  19. 10 Jun, 2020 3 commits
    • Jesse Chan's avatar
      DeskClock: also apply disabled color to annotations · 9026139e
      Jesse Chan authored
      Change-Id: Ia2c7e28e161f1a0f01de13deff4d02a78c34f8d5
      9026139e
    • Michael W's avatar
      DeskClock: Come to the dark side... · 6fcbe7e9
      Michael W authored
      ... we have cookies
      
      * Move minSdkVersion to 24 so the notification actions don't use the
        icons anymore and we can just tint the icons black to fit onto the new
        accent color used e.g. for the FABs
      * Move accent color to an own color name which is defined differently
        for values and values-night
      * Background: Keep blue for light theme but use grey for night one
      
      Change-Id: Ib14044fc9c6de15453891638581a7e3f4d10c6c5
      6fcbe7e9
    • Michael W's avatar
      DeskClock: Rework notification channel implementation · 22b6cf2f
      Michael W authored
      
      
      * Alarm notifications etc. are important and should be on high
        importance level.
      * On contrast, upcoming alarms etc. should not have sounds or vibrations
        attached to them.
      * In addition, we need to fix strings for notification channel.
      * In order to achieve this, we need to create some new channels because
        you can't change the priority for existing channels
      * Delete old channels on boot and update the names of existing channels if
        they already exist (they get created with the first notification
        requiring them)
      * Move creation of upcoming alarm notifications into one place
      Co-authored-by: default avatarWang Han <416810799@qq.com>
      Change-Id: I6d2e9abd6a822a62b3313c62b0617d8d9211948e
      22b6cf2f
  20. 07 Jun, 2020 2 commits
  21. 05 Jun, 2020 1 commit
    • Wang Han's avatar
      Revert "Remove max aspect ratio." · 4fdeff36
      Wang Han authored
       * We don't need this when target SDK is 29, see docs:
         If your app targets Android 8.0 (API level 26) or higher, it
         fills the entire screen, according to its layout.
      
      This reverts commit b7abe063.
      
      Change-Id: I9442b05b8c4d6213676943163e3c0b995047d303
      4fdeff36
  22. 23 May, 2020 2 commits
  23. 21 May, 2020 3 commits
    • Colin Marsch's avatar
      AOSP/DeskClock - Added SET_ALARM permission check · f97987e3
      Colin Marsch authored
      
      
      Added SET_ALARM permission check for the HandleApiCalls activity.
      
      Test: manual - tested the DeskClock UI manually, as well as testing the
      alarm, stopwatch and timer
      
      Forrest run: go/forrest-run/L31100000555861022 to test CtsMediaTestCases module
      
      Change-Id: I9e42e0bc3eb1375d170091ec79315967be1efd32
      Signed-off-by: default avatarJesse Chan <jc@lineageos.org>
      f97987e3
    • Raman Tenneti's avatar
      AOSP/DeskClock - Updated to sdkVersion 29. · 8c6c3741
      Raman Tenneti authored
      
      
      Changed android:name for HandleApiCalls and HandleSetAlarmApiCalls to be same as
      Google Playstore's Clock app. Updated minSdkVersion to "23"  ala Clock app.
      
      BUG: 133177396
      BUG: 143990962
      BUG: 150612638
      
      Test: manual - Tested the DeskClock UI manually and tested the alarm, stopwatch and timer.
      
      $ make -j 40
      
      $ ls -l  out/target/product/bonito/product/app/DeskClock/DeskClock.apk
      -rw-r----- 1 rtenneti primarygroup 6125545 Apr 27 12:57 out/target/product/bonito/product/app/DeskClock/DeskClock.apk
      
      $ adb install -r out/target/product/generic/system/product/app/DeskClock/DeskClock.apk
      
      + Verified by setting up the alaram and waiting for the alarm to go off.
      
      Change-Id: I5f4c8a4701635f43c9057759a2ad702968a04020
      Signed-off-by: default avatarJesse Chan <jc@lineageos.org>
      8c6c3741
    • Raman Tenneti's avatar
      AOSP/DeskClock - Updated to sdkVersion 29. · 732cd5c2
      Raman Tenneti authored
      + Fixed all the comments from jplemieux@ in CL: https://android-review.googlesource.com/c/platform/packages/apps/DeskClock/+/1161143
      + Incorporated changes from Luca Stefani (https://android-review.googlesource.com/c/platform/packages/apps/DeskClock/+/1162919)
      
      BUG: 133177396
      BUG: 143990962
      
      Test: manual - Tested the DeskClock UI manually and tested the alarm, stopwatch and timer.
      
      $ make -j 40
      
      $ ls -l out/target/product/generic/system/product/app/DeskClock/DeskClock.apk
        -rw-r--r-- 1 rtenneti .... 6436375 Nov 11 16:09 out/target/product/generic/system/product/app/DeskClock/DeskClock.apk
      
      $ adb install -r out/target/product/generic/system/product/app/DeskClock/DeskClock.apk
      
      + Verified by setting up the alaram and waiting for the alarm to go off.
        "Clock has stopped" wasn't displayed. Noted there were no exceptions in the logs. (b/135587258)
      
        ++ The following are the results from logcat with manual alaram testing
            On x20web site in my home directory - ~rtenneti/android/
                  logcat.out.1111.1610
                  logcat.out.1112.1603
      
        ++ Verified there were no java exceptions.
        $ grep -n -i 'exception' ~rtenneti/android/logcat.out.1111.1610 | wc -l
         0
      
        ++ Verified Alarm was firing (results are in x20web site)
        $ grep -n -i 'alarm' ~rtenneti/android/logcat.out.1111.1610
          (for an alarm that was set to 19:12:00 at 19:11:19. Results from Alarm firing).
      
        6880:11-11 19:11:19.403  8813  8863 I AlarmClock: Registering instance: 1
        6881:11-11 19:11:19.405  8813  8863 I AlarmClock: Setting high notification state to instance 1
        6882:11-11 19:11:19.406  8813  8863 V AlarmClock: *** notifyChange() id: 1 url content://com.android.deskclock/instances/1
        6883:11-11 19:11:19.408  8813  8863 V AlarmClock: Displaying high priority notification for alarm instance: 1
        6884:11-11 19:11:19.414  8813  8863 I AlarmClock: Scheduling state change 5 to instance 1 at Mon 7:12 PM (1573517520000)
        6885:11-11 19:11:19.419  8813  8863 I AlarmClock: Setting upcoming AlarmClockInfo for alarm: 1
        6887:11-11 19:11:19.423  1329  1329 V SettingsProvider: Notifying for 0: content://settings/system/next_alarm_formatted
        ....
        7143:11-11 19:12:00.031  1329  1329 V SettingsProvider: Notifying for 0: content://settings/system/next_alarm_formatted
        7144:11-11 19:12:00.032  1329  1329 D ConditionProviders.SCP: onReceive android.app.action.NEXT_ALARM_CLOCK_CHANGED
        ....
        7152:11-11 19:12:00.055  8813  8813 I AlarmClock: Setting fire state to instance 1
        7153:11-11 19:12:00.105  8813  8813 V AlarmClock: *** notifyChange() id: 1 url content://com.android.deskclock/instances/1
      
      
        7154:11-11 19:12:00.112  8813  8813 D Events  : [Alarm] [Fire]
        7155:11-11 19:12:00.113  8813  8813 I AlarmClock: Scheduling state change 6 to instance 1 at Mon 7:22 PM (1573518120000)
        7156:11-11 19:12:00.118  8813  8813 I AlarmClock: Canceling upcoming AlarmClockInfo
        7157:11-11 19:12:00.123  8813  8813 V AlarmClock: AlarmService.start with instance: 1
        7158:11-11 19:12:00.124  8813  8813 V AlarmClock: Displaying alarm notification for alarm instance: 1
        7159:11-11 19:12:00.130  8813  8813 V AlarmClock: Clearing notifications for alarm instance: 1
        7161:11-11 19:12:00.145  8813  8813 V AlarmClock: AlarmKlaxon.start()
        ...
      
      Change-Id: I005530d5d82568e028acb4cbad1f3212fc9c61a2
      Signed-off-by: default avatarJesse Chan <jc@lineageos.org>
      732cd5c2
  24. 06 May, 2020 1 commit
  25. 23 Apr, 2020 1 commit
  26. 30 Mar, 2020 1 commit
  27. 27 Mar, 2020 1 commit
    • Marko Man's avatar
      Change most notfications category · a3f4392a
      Marko Man authored
      Due to androids limited dnd implementation all notifications with
      category_alarm will make sound even in dnd mode. Not all DeskClock's
      notifications are actually alarms. Change appropriate notifications
      to category_event, so that notifications sounds an be muted when
      Do not disturb is turned on.
      
      Change-Id: I5a5eb26fac85357e108e3008f7b57f053f81b599
      a3f4392a
  28. 20 Mar, 2020 1 commit
    • Danny Baumann's avatar
      Remove max aspect ratio. · b7abe063
      Danny Baumann authored
      Make sure the app is displayed in full-screen on devices with
      18:9 and 19:9 screen by removing the default max aspect ratio set for
      apps that target older API levels than O.
      
      Change-Id: I715d254e98af261ce6b881bb0c2b79eb32b4bd9c
      b7abe063