Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd18a805 authored by Flavio Lerda's avatar Flavio Lerda
Browse files

Update spacing of buttons. 

Also:
- clean up a couple of unused dimensions.
- fix padding at top and bottom of history items.

Bug: 5257946
Change-Id: I23416d1a400b1bd02ab74ba9e4fc3cb274fdc5a9
parent f1c933a0

res/layout/call_detail.xml

+2 −2
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ 
            android:id="@+id/voicemail_container"

            android:layout_width="match_parent"

            android:layout_height="wrap_content"

            android:paddingBottom="@dimen/call_log_icon_margin"

            android:paddingBottom="@dimen/call_detail_button_spacing"

            android:layout_below="@id/blue_separator"

            android:background="@android:color/black"

        >
@@ -135,7 +135,7 @@ 
        <FrameLayout android:id="@+id/call_and_sms_container"

            android:layout_width="match_parent"

            android:layout_height="wrap_content"

            android:layout_marginBottom="@dimen/call_log_icon_margin"

            android:layout_marginBottom="@dimen/call_detail_button_spacing"

            android:layout_below="@id/voicemail_container"

            android:background="@android:color/black"

        >

res/layout/call_detail_history_header.xml

+2 −2
Original line number Diff line number Diff line
@@ -48,8 +48,8 @@ 
    <View

        android:id="@+id/header_voicemail_container"

        android:layout_width="match_parent"

        android:layout_height="142dip"

        android:layout_marginBottom="@dimen/call_log_icon_margin"

        android:layout_height="140dip"

        android:layout_marginBottom="@dimen/call_detail_button_spacing"

    />

    <!-- Call and SMS -->

    <View

res/layout/call_detail_history_item.xml

+2 −1
Original line number Diff line number Diff line
@@ -19,7 +19,8 @@ 
    android:layout_width="match_parent"

    android:layout_height="wrap_content"

    android:minHeight="@dimen/call_log_list_item_height"

    android:paddingTop="@dimen/call_log_icon_margin"

    android:paddingTop="@dimen/call_log_inner_margin"

    android:paddingBottom="@dimen/call_log_inner_margin"

    android:paddingLeft="@dimen/call_log_indent_margin"

    android:paddingRight="@dimen/call_log_outer_margin"

    android:orientation="vertical"

res/layout/playback_layout.xml

+2 −3
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ 
        <LinearLayout

            android:layout_width="match_parent"

            android:layout_height="58dip"

            android:layout_marginRight="2dip"

            android:layout_marginRight="@dimen/call_detail_button_spacing"

            android:background="@drawable/dialpad_background"

            android:layout_weight="1"

        >
@@ -31,7 +31,6 @@ 
        <LinearLayout

            android:layout_width="match_parent"

            android:layout_height="58dip"

            android:layout_marginLeft="2dip"

            android:background="@drawable/dialpad_background"

            android:layout_weight="1"

        >
@@ -50,7 +49,7 @@ 
        android:layout_height="80dip"

        android:background="@drawable/dialpad_background"

        android:layout_below="@id/buttons_linear_layout"

        android:layout_marginTop="4dip"

        android:layout_marginTop="@dimen/call_detail_button_spacing"

    >

        <!-- SeekBar left-right margin decreased from redlines 72dip by 8dip to account for

             half thumb width (thumb is 16dip).

res/values/dimens.xml

+1 −2
Original line number Diff line number Diff line
@@ -249,9 +249,8 @@ 
    <dimen name="call_log_indent_margin">24dip</dimen>

    <dimen name="call_log_list_item_height">56dip</dimen>

    <dimen name="call_log_list_contact_photo_size">64dip</dimen>

    <dimen name="call_detail_contact_background_height">174dip</dimen>

    <dimen name="call_detail_contact_name_margin">24dip</dimen>

    <dimen name="call_detail_action_bar_height">60dip</dimen>

    <dimen name="call_detail_button_spacing">2dip</dimen>



    <!-- Empty message margins -->

    <dimen name="empty_message_top_margin">48dip</dimen>