Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc8f272a authored by Wenyi Wang's avatar Wenyi Wang
Browse files

Second pass on fragments navigation

1. Fix some janky animation when opening or updating groups.
  a. Use FragmentTransaction#replace instead of FragmentTransaction#add
     so that mAllFragment will not appear before group members are loaded.
  b. Change group URI and reuse existing group fragment to reload group
     members, instead of popping old group fragment and adding new group
     fragment, when user opens another group from a group view.
2. Fix an error in ContactsDrawerActivity#updateFilterMenu.
3. Move code to handle new Intent from PeopleActivity to group fragment.
4. Initialize ContactListFilterController in
   DefaultContactBrowseListFragment#onCreate rather than onActivityCreated.
   Because onActivityCreated will be called when fragment is removed and
   added back, and we don't want to set filter again and again.
5. Fix a bug where activity title is not updated when nagivating from
   account A --> group X --> account A.
6. Move all group actions from GroupUtil to ContactSaveService.
7. Other minor refactoring and cleanup.

Bug: 30944495

Test: manual - navigate between fragments, rotate, press Back/Home/Recent
               button, search, multi-select, modify group members,
               add/delete groups, view/edit/add groups from
               ContactsTests.apk and when no contacts view is shown.

Change-Id: I27c89b4125e55b67921a37f2092fde839a9f8ed4
parent 61f9b837
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment