Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit ae48e81b authored by Makoto Onuki's avatar Makoto Onuki
Browse files

Fix crash in StreamItemEntry.checkDecoded()

This method is meant to check if decodeHtml() was called prior to
getDecodedText() / getDecodedComments() calls.

The logic was flawed because HtmlUtils.fromHtml will return null
for empty strings, so even when decodeHtml() was called and mComments
wasn't null, mDecodedComments may still be null.

Let's just not try to be smart and introduce a new flag for this purpose.

Also changed the test-only constructor to a static method to make sure
it won't get called from the main apk.

Bug 6367860

Change-Id: I9a774e010666bd5a83ef916e817b50052afd325f
parent c019a80d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment