Follow up to EditSchema parser
- Now AccountType.addKind() throws DefinitionException instead of just logging. - Now the test contacts.xml (= test_basic_contacts.xml) defines "event" and "relationship" DataKinds too. BUA should be able to copy this file. - Added another xml, contacts_fallback.xml, to the test apk. This defines what's equivalent to the fallback type. Unittests load this file directly and compares the result to the fallback account type. - Cleaned up existing account definitions in order to make sure contacts_fallback.xml is really identical to the fallback type. This includes: ** Now structured name, display name, phonetic name, and phone DataKinds all have 'kind.typeOverallMax = 1'. ** The "assistant" phone type is no longer a custom column. It's only used for the fallback type and I don't think it's too critical. - Also, NameKindBuilder no longer re-order phonetic fields, because no other account types do this. In the previous CL I did it because I thought that'd be more "correct", but on the second thought it's probably not a good idea to make too many non-critical changes at this point. Bug 5381810 Change-Id: Ie6a4eb3b876ab22a3dcdb6a9c278e387f8166125
Loading
Please register or sign in to comment