Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 726e6618 authored by Daniel Tschinder's avatar Daniel Tschinder
Browse files

Contacts: fix UI glitches 

http://code.google.com/p/cyanogenmod/issues/detail?id=3596

1. Missing space after number-label.
Fixed with margin

2. Group icon is not centered verticaly.

3. Number-label was flickering on redraw.
Was due to android:ellipsize, but as the number-label should never
be as long as the screen (even on my ldpi), this should be okay.

Change-Id: I58191ccce65924b72fd749118766784e702bbf5c
parent 64200740

res/layout-finger/recent_calls_list_group_item.xml

+16 −20
Original line number Original line Diff line number Diff line
@@ -52,7 +52,6 @@ 
        android:layout_marginLeft="4dip"

        android:layout_marginLeft="4dip"

    />

    />







    <TextView android:id="@+id/date"

    <TextView android:id="@+id/date"

        android:layout_width="wrap_content"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_height="wrap_content"
@@ -66,18 +65,31 @@ 
        android:singleLine="true"

        android:singleLine="true"

    />

    />

    

    

    <TextView android:id="@+id/label"

    <ImageView

        android:id="@+id/groupIndicator"

        android:layout_width="wrap_content"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_height="wrap_content"

        android:layout_toRightOf="@id/photo"

        android:layout_toRightOf="@id/photo"

        android:layout_alignWithParentIfMissing="true"

        android:layout_marginLeft="2dip"



        android:layout_centerVertical="true"

        android:src="@*android:drawable/expander_ic_minimized"

        android:gravity="center_vertical"

    />



    <TextView android:id="@+id/label"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_toRightOf="@id/groupIndicator"

        android:layout_alignParentBottom="true"

        android:layout_alignParentBottom="true"

        android:layout_marginBottom="8dip"

        android:layout_marginBottom="8dip"

        android:layout_marginTop="-10dip"

        android:layout_marginTop="-10dip"

        android:layout_marginLeft="10dip"

        android:layout_marginLeft="2dip"

        android:layout_marginRight="8dip"

        android:layout_alignWithParentIfMissing="true"

        android:layout_alignWithParentIfMissing="true"





        android:singleLine="true"

        android:singleLine="true"

        android:ellipsize="marquee"

        android:textAppearance="?android:attr/textAppearanceSmall"

        android:textAppearance="?android:attr/textAppearanceSmall"

        android:textStyle="bold"

        android:textStyle="bold"

    />

    />
@@ -120,22 +132,6 @@ 
        style="@*android:style/Widget.QuickContactBadge.WindowMedium"

        style="@*android:style/Widget.QuickContactBadge.WindowMedium"

    />

    />





    <ImageView

        android:id="@+id/groupIndicator"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_alignParentTop="true"

        android:layout_toRightOf="@id/photo"

        android:layout_above="@id/date"

        android:layout_alignWithParentIfMissing="true"

        android:layout_marginBottom="-10dip"

        android:layout_marginLeft="2dip"



        android:layout_centerVertical="true"

        android:src="@*android:drawable/expander_ic_minimized"

        android:gravity="center_vertical"

    />



    <TextView android:id="@+id/line1"

    <TextView android:id="@+id/line1"

        android:layout_width="wrap_content"

        android:layout_width="wrap_content"

        android:layout_height="wrap_content"

        android:layout_height="wrap_content"

res/layout-finger/recent_calls_list_item_layout.xml

+2 −2
Original line number Original line Diff line number Diff line
@@ -57,11 +57,11 @@ 
        android:layout_alignParentBottom="true"

        android:layout_alignParentBottom="true"

        android:layout_marginBottom="8dip"

        android:layout_marginBottom="8dip"

        android:layout_marginTop="-10dip"

        android:layout_marginTop="-10dip"

        android:layout_marginLeft="10dip"

        android:layout_marginLeft="4dip"

        android:layout_marginRight="8dip"

        android:layout_alignWithParentIfMissing="true"

        android:layout_alignWithParentIfMissing="true"





        android:singleLine="true"

        android:singleLine="true"

        android:ellipsize="marquee"

        android:textAppearance="?android:attr/textAppearanceSmall"

        android:textAppearance="?android:attr/textAppearanceSmall"

        android:textStyle="bold"

        android:textStyle="bold"

    />

    />

src/com/android/contacts/RecentCallsListActivity.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -799,7 +799,7 @@ public class RecentCallsListActivity extends ListActivity 




            if (!TextUtils.isEmpty(name)) {

            if (!TextUtils.isEmpty(name)) {

                views.line1View.setText(name);

                views.line1View.setText(name);

                views.labelView.setVisibility(View.VISIBLE);

                views.line1View.setVisibility(View.VISIBLE);





                // "type" and "label" are currently unused for SIP addresses.

                // "type" and "label" are currently unused for SIP addresses.

                CharSequence numberLabel = null;

                CharSequence numberLabel = null;