Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51f1071a authored by Katherine Kuan's avatar Katherine Kuan
Browse files

Allow phone contact card to switch b/t having/not having social updates 

- Make phone portrait and landscape layouts have all views necessary
to switch between showing/hiding social updates. Disable swipe
if only the detail fragment is showing.

- Make ContactDetailActivity use ContactDetailLayoutController to
reduce code duplication, add another state for fragment carousel
in ContactDetailLayoutController

- Make fragment widths in fragment carousel configurable based
on screen width instead of fixed dip value

- Make setAlphaLayerValue() save the alpha value if the view
isn't ready yet (otherwise it's a no-op and the caller must
call it setAlphaLayerValue again when the view is attached) -->
this allows us to remove the code to set fragments in the
fragment carousel every time the data is reloaded

- Remove enableAlphaLayer() code and just make the alpha layer
view visible in the XML

Bug: 5164029

Change-Id: I8f28ac27d125502a12221f084ce253611e6f78a1
parent 5a7063d7

res/layout/contact_detail_container_with_updates.xml→res/layout-sw580dp/contact_detail_container.xml

+6 −3
Original line number Diff line number Diff line
@@ -17,7 +17,9 @@ 
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

    android:layout_width="match_parent"

    android:layout_height="match_parent"

    android:orientation="vertical">

    android:orientation="vertical"

    android:background="@color/background_primary"

    android:padding="16dip">



    <android.support.v4.view.ViewPager

        android:id="@+id/pager"
@@ -32,6 +34,7 @@ 
        android:layout_alignParentTop="true"

        android:layout_alignParentLeft="true"

        android:layout_width="match_parent"

        android:layout_height="wrap_content"/>

        android:layout_height="wrap_content"

        android:visibility="gone"/>



</RelativeLayout>
 
 No newline at end of file

res/layout-w470dp/contact_detail_fragment.xml

+1 −2
Original line number Diff line number Diff line
@@ -75,8 +75,7 @@ 
        android:layout_width="match_parent"

        android:layout_height="match_parent"

        android:layout_alignParentLeft="true"

        android:layout_alignParentTop="true"

        android:visibility="gone"/>

        android:layout_alignParentTop="true"/>



    <View

        android:id="@+id/touch_intercept_overlay"

res/layout-w470dp/contact_detail_updates_fragment.xml

+1 −2
Original line number Diff line number Diff line
@@ -31,8 +31,7 @@ 
        android:layout_width="match_parent"

        android:layout_height="match_parent"

        android:layout_alignParentLeft="true"

        android:layout_alignParentTop="true"

        android:visibility="gone"/>

        android:layout_alignParentTop="true"/>



    <View

        android:id="@+id/touch_intercept_overlay"

res/layout/carousel_about_tab.xml

+1 −2
Original line number Diff line number Diff line
@@ -43,8 +43,7 @@ 
        android:layout_height="match_parent"

        android:layout_alignParentLeft="true"

        android:layout_alignParentTop="true"

        android:layout_marginBottom="@dimen/detail_tab_carousel_tab_label_height"

        android:visibility="gone"/>

        android:layout_marginBottom="@dimen/detail_tab_carousel_tab_label_height"/>



    <TextView

        android:id="@+id/label"