LineageDatabaseHelper: Downgrade DB_VERSION to 13
Description
LineageDatabaseHelper: Downgrade DB_VERSION to 13
Issue(s)
Test environment
Prepare two q test builds one without and with this patch.
Prepare r test build without any patches.
Build 1:
-
DEVICES:FP3 -
BRANCH_NAME:v1-q
Job: https://gitlab.e.foundation/e/priv/os/build/-/jobs/206815
Build 2:
-
DEVICES:FP3 -
BRANCH_NAME:v1-q -
FEATURE_BRANCH:3712-q-downgradeDB
Job: https://gitlab.e.foundation/e/priv/os/build/-/jobs/207383
Build 3:
-
DEVICES:FP3 -
BRANCH_NAME:v1-r
Job: https://gitlab.e.foundation/e/priv/os/build/-/jobs/207387
Test procedures
- Flash the q build without this patch and boot up (We would be on
DB_VERSION15) - Flash the q build with this patch and notice that the phone boots up fine. (
DB_VERSIONwould be downgraded to 13 then) - Flash the r build on top of this and notice that the phone boots up fine.
Technical details
-
We had previously bumped the
DB_VERSIONto:- 14 (which set
STATUS_BAR_CLOCKto 1 andSTATUS_BAR_BATTERY_STYLEto 2) - 15 (which set
STATUS_BAR_CLOCKto 2 andSTATUS_BAR_BATTERY_STYLEto 0)DB_VERSION15 is essentially reverting to version 13, and undoing the changes that version 14 did.
- 14 (which set
-
Our R based builds follow upstream (which bumped the
DB_VERSIONto 14, from 13 onlineage-17.1) This breaks boot, for a user trying to transition with a Q userdata to R. -
At this point in time, it makes sense for us to force downgrade the
DB_VERSIONto 13, so that our upgrade path is left intact and we can follow upstream from R as well.
Check list
-
Self review -
Test procedure explained -
Tested on fresh install -
Tested applied as an update -
License -
Internal documentation -
User documentation