Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebeaa36f authored by Shikha Panwar's avatar Shikha Panwar
Browse files

Secretkeeper: Disable a replay protection VTS 

This test does not account for potentially missing Sk HAL. Ideally, the
test should pass on those devices too (since Sk is an optional HAL at
the moment).

This test uses should_panic expecting the client code to panic on
processing the message, but that code is never executed because the
backend is not present & the method doesn't panic & the test fails.

As a mitigation, #ignore the test.

Bug: 317416663
Test: VTS show "IGNORED"

Change-Id: I2f1bb45361943f22d8cadc929059c65cb3120f3f
parent 3526efd0

security/secretkeeper/aidl/vts/secretkeeper_test_client.rs

+2 −0
Original line number Original line Diff line number Diff line
@@ -513,6 +513,8 @@ fn secret_management_replay_protection_seq_num_per_session() { 




// This test checks that Secretkeeper rejects requests with out of order [`RequestSeqNum`]

// This test checks that Secretkeeper rejects requests with out of order [`RequestSeqNum`]

#[test]

#[test]

// TODO(b/317416663): This test fails, when HAL is not present in the device. Refactor to fix this.

#[ignore]

#[should_panic]

#[should_panic]

fn secret_management_replay_protection_out_of_seq_req_not_accepted() {

fn secret_management_replay_protection_out_of_seq_req_not_accepted() {

    let sk_client = setup_client!();

    let sk_client = setup_client!();