Commit 80feb3cd authored Oct 24, 2019 by Ahmed ElArabawy

Wifi: Handle invalid error values from vendor HAL

The HAL shim (default implementation) expects all vendor hal functions
to return valid wifi_error values. In case the vendor hal returning a
value outside this range of values, the HAL service crashes.

This commit is to handle this type of error by defaulting to
WIFI_ERROR_UNKNOWN.

Bug: 143317834
Test: Manual
Test: Pass an invalid error code, and make sure it is properly handled
Change-Id: Ifaba8a7e4e866a2be154c9dcaeb521cd758010ee

parent f19af45c

wifi/1.4/default/wifi_status_util.cpp

+6 −0

Original line number	Diff line number	Diff line
		@@ -46,6 +46,8 @@ std::string legacyErrorToString(legacy_hal::wifi_error error) {
		return "BUSY";
		case legacy_hal::WIFI_ERROR_UNKNOWN:
		return "UNKNOWN";
		default:
		return "UNKNOWN ERROR";
		}
		}

		@@ -92,6 +94,10 @@ WifiStatus createWifiStatusFromLegacyError(legacy_hal::wifi_error error,

		case legacy_hal::WIFI_ERROR_UNKNOWN:
		return createWifiStatus(WifiStatusCode::ERROR_UNKNOWN, "unknown");

		default:
		return createWifiStatus(WifiStatusCode::ERROR_UNKNOWN,
		"unknown error");
		}
		}