Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80485717 authored by Valerie Hau's avatar Valerie Hau
Browse files

Fix getDisplayCapabilitiesBasic VTS test 

Old test checked error code when calling getBrightnessSupport in the
getDisplayCapabilitiesBasic test.  However, it is possible that the
function is not implemented (UNSUPPORTED).  We want to return normally
and use the returned supported boolean to check this instead.

Bug: 132043561, 132056857
Test: VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I94f8f39ba9129c4a8d939a5385538db3489c46b9
parent 7af01ada

graphics/composer/2.3/utils/vts/ComposerVts.cpp

+2 −4
Original line number Diff line number Diff line
@@ -192,10 +192,8 @@ Error ComposerClient::getDisplayCapabilities( 


bool ComposerClient::getDisplayBrightnessSupport(Display display) {

    bool support = false;

    mClient->getDisplayBrightnessSupport(display, [&](const auto& error, const auto& tmpSupport) {

        ASSERT_EQ(Error::NONE, error) << "failed to get brightness support";

        support = tmpSupport;

    });

    mClient->getDisplayBrightnessSupport(

            display, [&](const auto& /*error*/, const auto& tmpSupport) { support = tmpSupport; });

    return support;

}