Commit 731cc9e4 authored May 06, 2022 by Keith Mok

vehicle-aidl: Fix thread join would block

There is race condition in RecurrentTimer.cpp
for thread creation whcih created in initialization
list instead of constructor which the class member
variables are not init yet.

Bug: 231668271
Test: android.hardware.automotive.vehicle@V1-default-service_fuzzer
Change-Id: I7dfdff7aa3df4e4451522ad167863a41e27a349c

parent 48cd846f

automotive/vehicle/aidl/impl/utils/common/src/RecurrentTimer.cpp

+3 −1

Original line number	Diff line number	Diff line
		@@ -29,7 +29,9 @@ namespace vehicle {

		using ::android::base::ScopedLockAssertion;

		RecurrentTimer::RecurrentTimer() : mThread(&RecurrentTimer::loop, this) {}
		RecurrentTimer::RecurrentTimer() {
		mThread = std::thread(&RecurrentTimer::loop, this);
		}

		RecurrentTimer::~RecurrentTimer() {
		{