Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7063932f authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Use PLOG instead of printing errno"

parents 87ef3447 1accab96

automotive/can/1.0/default/libnetdevice/NetlinkSocket.cpp

+1 −1
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ bool NetlinkSocket::receiveAck() { 
        // Found error/ack message, return status.

        auto nlerr = reinterpret_cast<struct nlmsgerr*>(NLMSG_DATA(nlmsg));

        if (nlerr->error != 0) {

            LOG(ERROR) << "Received Netlink error message: " << nlerr->error;

            LOG(ERROR) << "Received Netlink error message: " << strerror(-nlerr->error);

            return false;

        }

        return true;

automotive/can/1.0/default/libnetdevice/common.cpp

+2 −3
Original line number Diff line number Diff line
@@ -28,9 +28,8 @@ unsigned int nametoindex(const std::string& ifname) { 
    const auto ifidx = if_nametoindex(ifname.c_str());

    if (ifidx != 0) return ifidx;



    const auto err = errno;

    if (err != ENODEV) {

        LOG(ERROR) << "if_nametoindex(" << ifname << ") failed: " << err;

    if (errno != ENODEV) {

        PLOG(ERROR) << "if_nametoindex(" << ifname << ") failed";

    }

    return 0;

}