Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30fa141c authored by Kalesh Singh's avatar Kalesh Singh
Browse files

memtrack: Update AIDL memtrack hal documentation 

Fix Memtrack GRAPHICS type definition to also inculde
GPU-mapped DMA-BUF memory.

Clarify SMAPS_UNACCOUTNED should also include memory
mapped with VM_PFNMAP set.

Bug: 192384999
Test: N/A
Change-Id: I5370efa731bc6307e4fe9b454796361e9a1ac5eb
parent 05e6b870

memtrack/aidl/android/hardware/memtrack/IMemtrack.aidl

+10 −4
Original line number Original line Diff line number Diff line
@@ -31,12 +31,14 @@ import android.hardware.memtrack.MemtrackType; 
 * accounting for stride, bit depth, rounding up to page size, etc.

 * accounting for stride, bit depth, rounding up to page size, etc.

 *

 *

 * The following getMemory() categories are important for memory accounting in

 * The following getMemory() categories are important for memory accounting in

 * `dumpsys meminfo` and should be reported as described below:

 * Android frameworks (e.g. `dumpsys meminfo`) and should be reported as described

 * below:

 *

 *

 * - MemtrackType::GRAPHICS and MemtrackRecord::FLAG_SMAPS_UNACCOUNTED

 * - MemtrackType::GRAPHICS and MemtrackRecord::FLAG_SMAPS_UNACCOUNTED

 *     This should report the PSS of all DMA buffers mapped by the process

 *     This should report the PSS of all CPU-Mapped DMA-BUFs (buffers mapped into

 *     with the specified PID. This PSS can be calculated using ReadDmaBufPss()

 *     the process address space) and all GPU-Mapped DMA-BUFs (buffers mapped into

 *     form libdmabufinfo.

 *     the GPU device address space on behalf of the process), removing any overlap

 *     between the CPU-mapped and GPU-mapped sets.

 *

 *

 * - MemtrackType::GL and MemtrackRecord::FLAG_SMAPS_UNACCOUNTED

 * - MemtrackType::GL and MemtrackRecord::FLAG_SMAPS_UNACCOUNTED

 *     This category should report all GPU private allocations for the specified

 *     This category should report all GPU private allocations for the specified
@@ -46,6 +48,10 @@ import android.hardware.memtrack.MemtrackType; 
 *     Any other memory not accounted for in /proc/<pid>/smaps if any, otherwise

 *     Any other memory not accounted for in /proc/<pid>/smaps if any, otherwise

 *     this should return 0.

 *     this should return 0.

 *

 *

 * SMAPS_UNACCOUNTED memory should also include memory that is mapped with

 * VM_PFNMAP flag set. For these mappings PSS and RSS are reported as 0 in smaps.

 * Such mappings have no backing page structs from which PSS/RSS can be calculated.

 *

 * Constructor for the interface should be used to perform memtrack management

 * Constructor for the interface should be used to perform memtrack management

 * setup actions and must be called once before any calls to getMemory().

 * setup actions and must be called once before any calls to getMemory().

 */

 */