Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d814ce5 authored by Changyeon Jo's avatar Changyeon Jo
Browse files

Update CameraStreamBuffering test case 

CameraStreamBuffering test case intentionally calls
setMaxFramesInFight() with very large integer value to verify that API
handles unreasonaly large value properly.  A type of its parameter is
changed from unsigned 32-bit integer to signed 32-bit integer in the
latest EVS interface definition written in the stable AIDL.  To adapt a
test case, this CL updates it to use std::numeric_limits<int32_t>::max()
instead of 0xFFFFFFFF, which is translated as -1 in signed 32-bit integer
format.

Bug: 226628778
Test: atest VtsHalEvsV1_1TargetTest
      atest VtsHalEvsTargetTest
Change-Id: Ic35c6c962617825bc271cec8544770340db7728a
parent d5bc92e9

automotive/evs/1.1/vts/functional/VtsHalEvsV1_1TargetTest.cpp

+2 −1
Original line number Diff line number Diff line
@@ -563,7 +563,8 @@ TEST_P(EvsHidlTest, CameraStreamBuffering) { 
        activeCameras.push_back(pCam);



        // Ask for a very large number of buffers in flight to ensure it errors correctly

        Return<EvsResult> badResult = pCam->setMaxFramesInFlight(0xFFFFFFFF);

        Return<EvsResult> badResult =

                pCam->setMaxFramesInFlight(std::numeric_limits<int32_t>::max());

        EXPECT_EQ(EvsResult::BUFFER_NOT_AVAILABLE, badResult);



        // Now ask for exactly two buffers in flight as we'll test behavior in that case

automotive/evs/aidl/vts/VtsHalEvsTargetTest.cpp

+1 −1
Original line number Diff line number Diff line
@@ -526,7 +526,7 @@ TEST_P(EvsAidlTest, CameraStreamBuffering) { 
        mActiveCameras.push_back(pCam);



        // Ask for a very large number of buffers in flight to ensure it errors correctly

        auto badResult = pCam->setMaxFramesInFlight(0xFFFFFFFF);

        auto badResult = pCam->setMaxFramesInFlight(std::numeric_limits<int32_t>::max());

        EXPECT_TRUE(!badResult.isOk() && badResult.getServiceSpecificError() ==

                                                 static_cast<int>(EvsResult::INVALID_ARG));