Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf7f5302 authored by Sooraj Sasindran's avatar Sooraj Sasindran Committed by Robert Greenwalt
Browse files

DO NOT MERGE - Issue Finish command even if a transaction failed 

Was only sending FINISH to modems that hadn't errored.

bug: 19996651
Change-Id: I958524f0905644eb56b64d217f61ea4f671b2158
parent b571fda6

src/java/com/android/internal/telephony/ProxyController.java

+8 −13
Original line number Diff line number Diff line
@@ -467,7 +467,6 @@ public class ProxyController { 
        // Issue FINISH

        synchronized(mSetRadioAccessFamilyStatus) {

            for (int i = 0; i < mProxyPhones.length; i++) {

                if (mSetRadioAccessFamilyStatus[i] != SET_RC_STATUS_FAIL) {

                logd("issueFinish: phoneId=" + i + " sessionId=" + sessionId

                        + " mTransactionFailed=" + mTransactionFailed);

                mRadioAccessFamilyStatusCounter++;
@@ -485,10 +484,6 @@ public class ProxyController { 
                    // At least one failed, mark them all failed.

                    mSetRadioAccessFamilyStatus[i] = SET_RC_STATUS_FAIL;

                }

                } else {

                    logd("issueFinish: Ignore already FAIL, Phone" + i + " sessionId=" + sessionId

                            + " mTransactionFailed =" + mTransactionFailed);

                }

            }

        }

    }