Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit c1e044a4 authored by Youming Ye's avatar Youming Ye Committed by Jack Yu
Browse files

Fix the physical slot validation and add unit test

Original validation validated physical slot index against the uicc
slot size, but the physical slot index comes from
TelephonyManager.getUiccSlotsInfo, which should be within the upper size
limit. Thus, simplifying the validation and validating against invalid
index only.

Also, the original validation using InValidPhoneId is not always
correct.

For a single SIM device, it may have may have logical slot 0 mapping to
physical slot 1. And it would be falsely invalid because physical slot 1
is equal to the total phone count.

Bug: 129425045
Test: CTS

Merged-In: I40f8359b94d270d54eca118be655517b4e178d34
Change-Id: I40f8359b94d270d54eca118be655517b4e178d34
(cherry picked from commit 46293417)
parent de6f4bf3
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment