Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit c10321d2 authored by Leon Scroggins III's avatar Leon Scroggins III
Browse files

Better logs for "Unable to generate SkImage/SkSurface"

In both cases, we don't have enough information to debug the issue, and
none of these have been reproducible, so we need more info in the logs
to know what's going on.

Combine the logs, since they're complaining about similar issues. Add
the data that was added in
https://skia-review.googlesource.com/c/skia/+/573879 for SkSurfaces.

Tested by converting the fatal logs to ALOGD and removing the if
statements. The logs then look like:
D RenderEngine: Unable to generate SkSurface. isTextureValid:1 dataspace:143261696
D RenderEngine: 	GrBackendTexture: (2208 x 1840) hasMipmaps: 0 isProtected: 0 texType: 1
D RenderEngine: 		GrGLTextureInfo: success: 0 fTarget: 0 fFormat: 0 colorType 4

Bug: 275475401
Bug: 242603007
Bug: 223762683
Test: m; look at logs
Change-Id: If1f3a933ea612279e9911c191ab2553160e744c2
parent 43b5d521
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment