Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9675a70 authored by Frederick Mayle's avatar Frederick Mayle
Browse files

binder: replace android_atomic_add with std::atomic 

android_atomic_add uses the STL atomics internally with
`memory_order_release`, so this should be a no-op.

Test: m
Change-Id: Ie63464d9cb607957c0b318e9cb8f778ce1aa6d83
parent 908b09ce

libs/binder/ProcessState.cpp

+1 −2
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ 
#include <binder/IPCThreadState.h>

#include <binder/IServiceManager.h>

#include <binder/Stability.h>

#include <cutils/atomic.h>

#include <utils/AndroidThreads.h>

#include <utils/String8.h>

#include <utils/Thread.h>
@@ -387,7 +386,7 @@ void ProcessState::expungeHandle(int32_t handle, IBinder* binder) 
}



String8 ProcessState::makeBinderThreadName() {

    int32_t s = android_atomic_add(1, &mThreadPoolSeq);

    int32_t s = mThreadPoolSeq.fetch_add(1, std::memory_order_release);

    pid_t pid = getpid();



    std::string_view driverName = mDriverName.c_str();

libs/binder/include/binder/ProcessState.h

+1 −1
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ private: 


    bool mForked;

    std::atomic_bool mThreadPoolStarted;

    volatile int32_t mThreadPoolSeq;

    std::atomic_int32_t mThreadPoolSeq;



    CallRestriction mCallRestriction;

};