Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a543a842 authored by Andrei Homescu's avatar Andrei Homescu
Browse files

libbinder: eliminate Binder.cpp dependency on IShellCallback 

Binder.cpp uses IShellCallback::asInterface to convert a Binder
to an IShellCallback, but the return value is not currently used.
This comments out that cast to eliminate the dependency on
IShellCallback, so we can build a minimal libbinder without it.

Bug: 224644083
Test: atest binderRpcTest
Change-Id: I209b1d2fd32cd9538c27aa263a6bf0a7e479fab1
parent 7c0b79f0

libs/binder/Android.bp

+1 −1
Original line number Diff line number Diff line
@@ -87,7 +87,6 @@ cc_defaults { 
        "FdTrigger.cpp",

        "IInterface.cpp",

        "IResultReceiver.cpp",

        "IShellCallback.cpp",

        "OS.cpp",

        "Parcel.cpp",

        "ParcelFileDescriptor.cpp",
@@ -234,6 +233,7 @@ cc_library { 


    srcs: [

        "IMemory.cpp",

        "IShellCallback.cpp",

        "LazyServiceRegistrar.cpp",

        "MemoryBase.cpp",

        "MemoryDealer.cpp",

libs/binder/Binder.cpp

+4 −3
Original line number Diff line number Diff line
@@ -648,12 +648,13 @@ status_t BBinder::onTransact( 
            for (int i = 0; i < argc && data.dataAvail() > 0; i++) {

               args.add(data.readString16());

            }

            sp<IShellCallback> shellCallback = IShellCallback::asInterface(

                    data.readStrongBinder());

            sp<IBinder> shellCallbackBinder = data.readStrongBinder();

            sp<IResultReceiver> resultReceiver = IResultReceiver::asInterface(

                    data.readStrongBinder());



            // XXX can't add virtuals until binaries are updated.

            // sp<IShellCallback> shellCallback = IShellCallback::asInterface(

            //        shellCallbackBinder);

            // return shellCommand(in, out, err, args, resultReceiver);

            (void)in;

            (void)out;